-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"cannot find formatter: rect" #317
Comments
Native functions and formatters (custom functions) share the same context. And we test for formatters first, then fallback to a closed list of native functions, and this is just a bad message in case the name is not found in the list. The reason Notice that this is just a warning, and Stylable still outputs the That being said, I think we should modify the behavior of native/custom functions to to be like JSX with capital first letter for custom and remove the native white-list altogether... |
I agree it's a bad error message; should be clear that it's looking in custom formatters then native, not found anything, but output it anyway. (Not sure it should output it anyway - doesn't that break our promise of catching errors before production?) |
I agree the error message could benefit from being more verbose. The idea to use capital letters to signify custom vs native feels slightly too magical to me. |
Perhaps in developer mode. we should run the end CSS through the official validator )https://github.com/w3c/css-validator) to alert developers of deprecated/ non-standard CSS? |
I think being tolerant here is the expected behavior. Stylable doesn't know what to do with the syntax, so it leaves it to CSS, which is tolerant as well and outputs a report with potential warnings (that might need an optional configuration).
This should be taken out to a separate discussion |
|
The text was updated successfully, but these errors were encountered: