Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't let user sign w/ a signer that's not in the setup #788

Closed
pythcoiner opened this issue Nov 3, 2023 · 2 comments
Closed

Don't let user sign w/ a signer that's not in the setup #788

pythcoiner opened this issue Nov 3, 2023 · 2 comments
Labels
Glitch A small annoyance in the GUI that is not entirely a bug GUI gui related

Comments

@pythcoiner
Copy link
Collaborator

If you try to sign with a signer w/ a key not related to your setup ( this xpub is in none of the paths), Liana let you start the signing process, we should filtering the signers and display oonly the ones having a fingerprint match w/ one of the descriptor xpubs.

He an example where i can sign w/ a specter using a key not related to the setup, also we should have a more explicit message:
image
@pythcoiner
Copy link
Collaborator Author

Note to myself: open an issue on Specter repo

@darosior darosior added GUI gui related Glitch A small annoyance in the GUI that is not entirely a bug labels Nov 3, 2023
@pythcoiner pythcoiner mentioned this issue Nov 21, 2023
Closed
@pythcoiner
Copy link
Collaborator Author

close, replaced by #831

@pythcoiner pythcoiner mentioned this issue Nov 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Glitch A small annoyance in the GUI that is not entirely a bug GUI gui related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darosior @pythcoiner