Skip to content

Commit a55b1c4

Browse files
Merge pull request ruby#53 from mmtk/mvh-remove-mmtk-env-vars
Remove MMTK_PLAN and THIRD_PARTY_HEAP_SIZE env vars
2 parents 1727ef1 + b06f8e9 commit a55b1c4

File tree

1 file changed

+1
-31
lines changed

1 file changed

+1
-31
lines changed

gc.c

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ MMTk_RubyUpcalls ruby_upcalls;
159159
static bool mmtk_enable = false;
160160

161161
#if USE_MMTK
162-
static const char *mmtk_env_plan = NULL;
163162
static const char *mmtk_pre_arg_plan = NULL;
164163
static const char *mmtk_post_arg_plan = NULL;
165164
static const char *mmtk_chosen_plan = NULL;
@@ -1967,7 +1966,6 @@ rb_objspace_alloc(void)
19671966

19681967
#if USE_MMTK
19691968
if (rb_mmtk_enabled_p()) {
1970-
19711969
MMTk_Builder *mmtk_builder = mmtk_builder_default();
19721970

19731971
mmtk_builder_set_plan(mmtk_builder, mmtk_chosen_plan);
@@ -15996,21 +15994,10 @@ rb_mmtk_parse_heap_limit(const char *argv, bool* had_error)
1599615994
}
1599715995

1599815996
void rb_mmtk_heap_limit(bool *is_dynamic, size_t *min_size, size_t *max_size) {
15999-
const char *envval;
1600015997
if (mmtk_max_heap_size > 0) {
1600115998
*is_dynamic = false;
1600215999
*min_size = 0;
1600316000
*max_size = mmtk_max_heap_size;
16004-
} else if ((envval = getenv("THIRD_PARTY_HEAP_LIMIT")) != 0) {
16005-
bool had_error = false;
16006-
size_t parsed_max = rb_mmtk_parse_heap_limit(envval, &had_error);
16007-
if (had_error) {
16008-
fprintf(stderr, "Error: Invalid THIRD_PARTY_HEAP_LIMIT: %s\n", envval);
16009-
abort();
16010-
}
16011-
*is_dynamic = false;
16012-
*min_size = 0;
16013-
*max_size = parsed_max;
1601416001
} else {
1601516002
const size_t default_min = 1024 * 1024;
1601616003
size_t default_max = rb_mmtk_available_system_memory() / 100 * rb_mmtk_heap_limit_percentage;
@@ -16035,15 +16022,6 @@ void rb_mmtk_pre_process_opts(int argc, char **argv) {
1603516022

1603616023
bool enable_rubyopt = true;
1603716024

16038-
mmtk_env_plan = getenv("MMTK_PLAN");
16039-
if (mmtk_env_plan) {
16040-
mmtk_enable = true;
16041-
}
16042-
16043-
if (getenv("THIRD_PARTY_HEAP_LIMIT")) {
16044-
mmtk_enable = true;
16045-
}
16046-
1604716025
for (int n = 1; n < argc; n++) {
1604816026
if (strcmp(argv[n], "--") == 0) {
1604916027
break;
@@ -16143,15 +16121,7 @@ void rb_mmtk_pre_process_opts(int argc, char **argv) {
1614316121
}
1614416122
}
1614516123

16146-
if (enable_rubyopt && mmtk_env_plan && mmtk_pre_arg_plan && strcmp(mmtk_env_plan, mmtk_pre_arg_plan) != 0) {
16147-
fputs("[FATAL] MMTK_PLAN and --mmtk-plan do not agree\n", stderr);
16148-
exit(EXIT_FAILURE);
16149-
}
16150-
16151-
if (enable_rubyopt && mmtk_env_plan) {
16152-
mmtk_chosen_plan = mmtk_env_plan;
16153-
}
16154-
else if (mmtk_pre_arg_plan) {
16124+
if (mmtk_pre_arg_plan) {
1615516125
mmtk_chosen_plan = mmtk_pre_arg_plan;
1615616126
}
1615716127
else {

0 commit comments

Comments
 (0)