Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub actions #197

Closed
amilan17 opened this issue Apr 18, 2024 · 2 comments · Fixed by #201
Closed

Update GitHub actions #197

amilan17 opened this issue Apr 18, 2024 · 2 comments · Fixed by #201

Comments

@amilan17
Copy link
Member

Details

From what I understand, the check can fail for two reasons.

  1. The XML is already generated in branch and there are no changes.
  2. Branch protections on master prevents automated updates.

I think the actions should follow the logic of A or B as described below.

Workflow A:

  • XML is generated in branch and action/check passes
  • Branch is merged into master
  • Check passes or there is no action/check at this point

Workflow B:

  • XML is not generated in the branch
  • Branch is merged into master
  • XML is generated

Requestor

Anna Milan (WMO), @amilan17
This was referenced Apr 18, 2024
Closed
Closed
@amilan17
Copy link
Member Author

@antoinemerle will fix the action

@antoinemerle
Copy link
Contributor

HI @amilan17 , fixed in a11d133
🎊

@amilan17 amilan17 linked a pull request May 29, 2024 that will close this issue
Fix Actions #201
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Actions wmo-im/CCT
2 participants
@amilan17 @antoinemerle