-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5-02-01 Methods (atmosphere) - Radar #158
Comments
I agree. I assume we already have unspecified under 'observing methods'. The observing method should just be RADAR. The Method details can be used to capture whether it is a Klystron or Magnetron. |
WMDS_Validation_Report_158_Radar_Method_v0.1.docx |
The report implies that I said that this sub-group of metadata could be dropped but not exactly correct. For other observing methods (i.e. radiosonde manufacture model) we use the Method Details to capture the additional metadata on the 'type' of instrument and I can't see why radar does not do the same. |
I agree with Tim that the same/consistent approach/methodology be used in all cases; otherwise there will be just an additional "issue" to deal with later on. |
I don't see a clear motive for characterizing radar type according to transmitter type. Intuitively, when looking at the hierarchy illustrated by the Select method, radar could stand alone without further sub-typing. But ... |
WMDS_Validation_Report_158_Radar_Method_v0.2.docx |
Looks good to me. I concur with this report. |
Sorry not my role to close the issue. |
This solution makes sense to me. |
Email comment Mustafa Sert: I requested to add to "Solid State" as sub-type of Radar Transmitter type a few months ago, because in WMO Radar Database, some Focal Points defined their Radars transmitter type as "Solid state". Also, some of them don't define their radar, so that I need "unspecified". According to WRD records, 10 radars defined as Solid State. (310 Klystron, 558 Magnetron, 135 Undefined). I'm not a radar expert. I don't know who offered "Transmitter Type" entry in WRD in 2011 while developping the WRD project in the begining, but I think IPET-OWR and related experts were aware it. |
Validation report accepted by peers |
Comment from Marco Gabella: "I write you on behalf of Urs, after having read your word file WMDS_Validation_Report_158_Radar_Method_v0.2.docx dated 5.5.20 To the best of my understanding, if associated to the code “RADAR”
|
Correct branch: https://github.com/wmo-im/wmds/tree/issue-158 |
Conclusion and Recommendation (copied from WMDS_Validation_Report_158_Radar_Method_v0.2.docx)
Removal (rather than obsoleting) is considered acceptable in this case. |
@joergklausen The branch changes may/may not be consistent with decision. Please review. https://github.com/wmo-im/wmds/blob/issue-158/tables_en/5-02-01.csv deleted 325 | \Atmosphere\Precipitation\Remote-sensing, active\Radio detection and ranging (Radar)\Magnetron | Magnetron added 183, \Atmosphere\Precipitation\Remote-sensing, active\Radio detection and ranging (Radar) profiler, Radio detection and ranging (Radar) profiler |
The final statement above makes sense to me, and was what we agreed. Just Radar (under Remote-sensing, active) is defined as the observing method. Additional information on the type of transmitter can be added (if known) into the method_details_user_tx field. |
This issue needs clarification. We cannot delete terms without following a deprecation process.
|
Element 183 in https://github.com/wmo-im/wmds/blob/issue-158/tables_en/5-02-01.csv must be called 'Radio detection and ranging (Radar)'. This element used to be a parent (of 325 and 326), but is now to become an endpoint. The recommendation by the domain experts was to eliminate 325 and 326, as well as of course 341. I think this should be respected. If you need to deprecate them, then please do it. |
removed "profiler" from 183 |
@joergklausen @KarlBureau -- please review the branch to verify that it's ready for fast-track. https://github.com/wmo-im/wmds/blob/issue-158/tables_en/5-02-01.csv deleted added In the codes registry, 183 will supersede 325 and 326. There was no term with the notation of 341 to delete. |
Thank you @amilan17 This is ready for FT. |
Approved by FT 2020-2 |
should be called differently, e.g., Radar (general), as only the endpoint is shown in OSCAR/Surface.
The text was updated successfully, but these errors were encountered: