Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-01-01 deprecate inapplicable and unknown #196

Closed
fstuerzl opened this issue Oct 21, 2020 · 6 comments
Closed

1-01-01 deprecate inapplicable and unknown #196

fstuerzl opened this issue Oct 21, 2020 · 6 comments
Assignees
Labels
Milestone

Comments

@fstuerzl
Copy link
Member

fstuerzl commented Oct 21, 2020

Branch

https://github.com/wmo-im/wmds/tree/Issue196

Summary and Purpose
Deprecate elements that make no sense from code table for observed variables.

Proposal
Deprecate entries "inapplicable" and "unknown" from code table 1-01-01.csv.

Reason
The elements "inapplicable" and "unknown" refering to the observed variable do not make sense in this context as there would be no observation to be described if the variable cannot be defined. While a nilReason makes a lot of sense in many code lists, this one is so fundamental that additional entries in the code table are required in case the existing elements are insufficient. Specifying a nilReason does not generate any meaningful information here.

@amilan17
Copy link
Member

Decision dependent on #199.

@joergklausen joergklausen added this to the FT-2021-1 milestone Dec 17, 2020
@joergklausen
Copy link
Contributor

@fstuerzl Create branch, expand on the reason

@fstuerzl fstuerzl self-assigned this Dec 17, 2020
@fstuerzl
Copy link
Member Author

@joergklausen
Copy link
Contributor

Unknown and Invalid marked as invalid. Confirmed that branch is correct.

@fstuerzl
Copy link
Member Author

@RMaerz, @tomkralidis, please review the proposal and confirm or comment.

@RMaerz
Copy link

RMaerz commented Jan 13, 2021

confirm !

@amilan17 amilan17 linked a pull request Jan 20, 2021 that will close this issue
@amilan17 amilan17 removed a link to a pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants