Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative env-dir breaks tools #555

Closed
henryiii opened this issue Jan 6, 2022 · 0 comments · Fixed by #556
Closed

Relative env-dir breaks tools #555

henryiii opened this issue Jan 6, 2022 · 0 comments · Fixed by #556
Labels

Comments

@henryiii
Copy link
Collaborator

henryiii commented Jan 6, 2022

Describe the bug

Nox currently sets TMPDIR to a relative path - this causes temporary directory creation to break for tools run after a session.cd. At least TMPDIR should be an absolute path - and maybe the return value from session.create_tmp should be absolute, too? (It really should be a pathlib.Path, but I'm referring to backwards compatible changes here ;) )

(see scientific-python/cookie#60 - Maturin expects TMPDIR to be an existent directory)

How to reproduce
Use chdir then try to run a tool that makes temporary directories.

Expected behavior
Temporary directory creation should not be broken after changing directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants