Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of py.path? #583

Closed
henryiii opened this issue Feb 28, 2022 · 4 comments · Fixed by #647
Closed

Remove usage of py.path? #583

henryiii opened this issue Feb 28, 2022 · 4 comments · Fixed by #647
Labels
dependencies Issues relating to a nox dependency

Comments

@henryiii
Copy link
Collaborator

Currently, there is a dependency on py.path, which pytest is trying to remove, and it seems like nox should remove it too, now that Python 3 is required (since quite a while, actually). py.path is not recommended for use: https://py.readthedocs.io/en/latest/path.html. This would reduce a dependency, too!

Looking through the usages, I see py.path.local.sysfind, which with a little effort could be replaced by Python 3's shutil.which. I see as_cwd, which could be handled pretty easily (ideally looking like the 3.11 context addition). That seems to be it for non-test usages.

@DiddiLeija DiddiLeija added the dependencies Issues relating to a nox dependency label Feb 28, 2022
@henryiii
Copy link
Collaborator Author

Would you like me to take a stab at it?

@DiddiLeija
Copy link
Collaborator

Sounds good to me 👍

@FollowTheProcess
Copy link
Collaborator

Great idea! 🎉

@henryiii
Copy link
Collaborator Author

henryiii commented Mar 8, 2022

FYI, removing it is really easy, but untangling the monkey patched unittests is not (though I love the test granularity that allows, so not against it, just extra work for this sort of a change). I should be able to finish it up later in the week month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues relating to a nox dependency
Development

Successfully merging a pull request may close this issue.

3 participants