Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails with latest MSVC (15.9) #46

Closed
jcelerier opened this issue Nov 21, 2018 · 5 comments · Fixed by #52
Closed

Build fails with latest MSVC (15.9) #46

jcelerier opened this issue Nov 21, 2018 · 5 comments · Fixed by #52

Comments

@jcelerier
Copy link
Collaborator

because of course ...

there is an immense amount of errors that appears simply by running the verdigris unit tests
@jcelerier
Copy link
Collaborator Author

jcelerier commented Nov 21, 2018 •
edited
Loading

I've sent an issue ticket to MS asking them to put the lib in their test suite: https://developercommunity.visualstudio.com/content/problem/388540/please-add-the-verdigris-library-to-your-c-test-su.html

@ogoffart
Copy link
Member

Could you paste example of these errors?

@jcelerier
Copy link
Collaborator Author

hmm, they're in french if it's not a problem, I don't know how I can ask cl.exe to output in english :

https://gist.github.com/jcelerier/e2ab319a4fa1d2343eb614827ba8f7d4

@jcelerier
Copy link
Collaborator Author

Still fails with VS 16. ("Visual Studio 2019") :(

@ogoffart
Copy link
Member

I have personally not tested MSVC 2019 yet.
If you manage to find a workaround, i'd be happy to apply it.

@arBmind arBmind mentioned this issue May 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed Qt 5.12 for MSVC-2019 hicknhack-software/Qt-Verdigris
2 participants
@ogoffart @jcelerier