Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing/style guide #168

Open
euank opened this issue Nov 15, 2017 · 2 comments
Open

Contributing/style guide #168

euank opened this issue Nov 15, 2017 · 2 comments

Comments

@euank
Copy link
Member

euank commented Nov 15, 2017

Pretty much irresponsible not to have one these days.

Note, this requires us settling on a JS style which we've avoided.. or documenting that each module gets to pick whatever it wants to (please no)

@brhoades
Copy link
Collaborator

Let's do eslint with airbnb.
https://github.com/airbnb/javascript

@euank
Copy link
Member Author

euank commented Nov 18, 2017

Thanks for the recommendation, LGTM @brhoades.

I made an initial shot at the eslint part over here: #171

I'm leaving this open since contributing.md still needs to exist regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants