Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration prop on the <Toaster /> is not recognized by typescript #50

Closed
Hugos68 opened this issue Jan 18, 2024 · 1 comment · Fixed by #55
Closed

Duration prop on the <Toaster /> is not recognized by typescript #50

Hugos68 opened this issue Jan 18, 2024 · 1 comment · Fixed by #55

Comments

@Hugos68
Copy link

Hugos68 commented Jan 18, 2024

Describe the bug

Title says it all, type definition isn't present for duration prop

Reproduction

  1. Create typescript sveltekit project
  2. Install svelte-sonner
  3. Add anywhere
  4. Add duration prop to
  5. Observer the type error

Logs

No response

System Info

System:
    OS: Windows 11 10.0.22621
    CPU: (12) x64 AMD Ryzen 5 5600 6-Core Processor
    Memory: 20.34 GB / 31.93 GB
  Binaries:
    Node: 20.10.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.2.3 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.12.1 - ~\AppData\Local\pnpm\pnpm.EXE
  Browsers:
    Edge: Chromium (120.0.2210.144)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @sveltejs/kit: ^2.3.2 => 2.3.2
    svelte: ^4.2.8 => 4.2.8
    svelte-sonner: ^0.3.11 => 0.3.11

Severity

annoyance

@enyo
Copy link
Contributor

enyo commented Jan 25, 2024

That's because it seems to have been removed:

93f282c#diff-0fe79c63b875a6f66b16c4c089951eeb191d9a9f657fb008c4c5b3eb918e264aL53

I just ran into the same problem and would also like to know the reasoning behind this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants