Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening multiple files from cli is treated as an argument #382

Open
Stoppedpuma opened this issue Jun 22, 2024 · 7 comments
Open

Opening multiple files from cli is treated as an argument #382

Stoppedpuma opened this issue Jun 22, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@Stoppedpuma
Copy link
Collaborator

Running oculante example-1.png example-2.png errors instead of opening just those two images. No idea if this should be treated as a bug report or as a feature request.

error: Found argument 'example-2.png' which wasn't expected, or isn't valid in this context

@woelper
Copy link
Owner

woelper commented Jun 24, 2024

This is intended as you can't open more than one image at a time.

@Stoppedpuma
Copy link
Collaborator Author

I guess this should be treated as a feature request then, as you state this is "intentional" would you be open to implementing this type of behaviour?

@woelper
Copy link
Owner

woelper commented Jun 25, 2024

I don't think that this would be high priority as a feature request. What would you expect to happen if you pass multiple files on the command line?

@woelper woelper added the enhancement New feature or request label Jun 25, 2024
@Stoppedpuma
Copy link
Collaborator Author

Stoppedpuma commented Jun 25, 2024

For example, you have multiple files in a directory called example-x.png as well as other files which you don't want to open. This is where using oculante example* would come into place. Good use cases for this feature are of course are opening all files of a certain extension, opening certain images spanning multiple directories, and to match the expectation of how other cli tools work (e.g. running cat *.txt to display the contents of all txt files in a directory which also has md files).

@woelper
Copy link
Owner

woelper commented Jun 25, 2024

And what exactly would happen after you open them? Do you mean they would be loaded into a sequence?

@Stoppedpuma
Copy link
Collaborator Author

Stoppedpuma commented Jun 25, 2024

Yes, the user should just be able to go through them with next and previous as if they are the only images loaded.

@Stoppedpuma
Copy link
Collaborator Author

0a2e918 makes #385 reproducible again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants