Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify IRRDB source #76

Open
momorientes opened this issue Oct 19, 2020 · 2 comments
Open

Specify IRRDB source #76

momorientes opened this issue Oct 19, 2020 · 2 comments

Comments

@momorientes
Copy link

In order to avoid conflicts it would be great to specify the source database, analog to bgpq3 -S <source>.

I'm happy to contribute some code but would like to discuss general design in advance.

The biggest question I'd like to discuss is in which way this should be passed via the API, some suggestions:

/<string:format>/<string:obj>/<string:policy>?source=<string>
/<string:source>/<string:format>/<string:obj>/<string:policy>
@benmaddison
Copy link
Member

In order to avoid conflicts it would be great to specify the source database, analog to bgpq3 -S <source>.

Agreed. There are a bunch of reasons one might want this.
For us, one use case is for lists that should use only "properly authenticated" sources.

I'm happy to contribute some code but would like to discuss general design in advance.

The biggest question I'd like to discuss is in which way this should be passed via the API, some suggestions:

/<string:format>/<string:obj>/<string:policy>?source=<string>
/<string:source>/<string:format>/<string:obj>/<string:policy>

I think there is a place for both forms:

  • if you want to pass an explicit list of source names, then the parameters form is what you want (even if the list is a singleton)
  • if you want to configure a named list of sources, and then pass the name (i.e. <string:source-list-name>), the path form is better

The use case you've described would probably require the first style. Ours would use the second.

Thoughts?

@benmaddison
Copy link
Member

Oh, and I think that if both named-list and parameter list were provided, the expected result would use the intersection of the two sets. Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants