adjust highwater check location to avoid masking return value

Author: JacobBarthelmeh

src/internal.c

@@ -9631,9 +9631,6 @@ static INLINE int Decrypt(WOLFSSH* ssh, byte* plain, const byte* input,
 
     ssh->rxCount += sz;
 
-    if (ret == WS_SUCCESS)
-        ret = HighwaterCheck(ssh, WOLFSSH_HWSIDE_RECEIVE);
-
     return ret;
 }
 
@@ -9902,9 +9899,6 @@ static INLINE int DecryptAead(WOLFSSH* ssh, byte* plain,
     AeadIncrementExpIv(ssh->peerKeys.iv);
     ssh->rxCount += sz;
 
-    if (ret == WS_SUCCESS)
-        ret = HighwaterCheck(ssh, WOLFSSH_HWSIDE_RECEIVE);
-
     return ret;
 }
 #endif /* WOLFSSH_NO_AEAD */
@@ -9940,6 +9934,14 @@ int DoReceive(WOLFSSH* ssh)
                     ssh->error = ret;
                     return WS_FATAL_ERROR;
                 }
+
+                ret = HighwaterCheck(ssh, WOLFSSH_HWSIDE_RECEIVE);
+                if (ret != WS_SUCCESS) {
+                    WLOG(WS_LOG_DEBUG, "PR: First HighwaterCheck fail");
+                    ssh->error = ret;
+                    ret = WS_FATAL_ERROR;
+                    break;
+                }
             }
             NO_BREAK;
 
@@ -10024,6 +10026,14 @@ int DoReceive(WOLFSSH* ssh)
                 }
             }
             ssh->processReplyState = PROCESS_PACKET;
+
+            ret = HighwaterCheck(ssh, WOLFSSH_HWSIDE_RECEIVE);
+            if (ret != WS_SUCCESS) {
+                WLOG(WS_LOG_DEBUG, "PR: HighwaterCheck fail");
+                ssh->error = ret;
+                ret = WS_FATAL_ERROR;
+                break;
+            }
             NO_BREAK;
 
         case PROCESS_PACKET: