Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in redis exceptions #102

Open
levic opened this issue Feb 3, 2025 · 1 comment
Open

Error in redis exceptions #102

levic opened this issue Feb 3, 2025 · 1 comment

Comments

@levic
Copy link

levic commented Feb 3, 2025

This showed up when testing #101

If the RedisLock fails to acquire a lock then it throws an exception with the exceptions module as the argument to the exception.

I'm not entirely sure whether the argument is expected to be Nothing or whether it should be LOCK_FAILED, but it seems unlikely that it was intended to be the module itself. This probably wouldn't matter too much, but it does prevent the exception being able to be pickled (which means multiprocessing can't handle a child process that throws this exception)

@wolph
Copy link
Owner

wolph commented Feb 5, 2025

You're right... silly error that needs to be fixed. It should just be nothing or some details about how/why locking failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants