Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling stacked when the zoom in. #20

Closed
opp100 opened this issue Jul 11, 2017 · 9 comments
Closed

Scrolling stacked when the zoom in. #20

opp100 opened this issue Jul 11, 2017 · 9 comments

Comments

@opp100
Copy link

opp100 commented Jul 11, 2017

Hey bro,

Thanks for you quick fixed the onLoadComplete bug. And then i found the scrolling will stacked in iOS if scale is not big enough. Which is meaning the page cannot be fully showed up, the edge of page will be cut off. But if continuously zoom in, the page could be showed correctly.

scale around 1.5 (the corner has been cut):
simulator screen shot 11 jul 2017 10 37 12

scale > 2 is showed correct:
simulator screen shot 11 jul 2017 10 37 20

*Android is working perfectly.

@wonday
Copy link
Owner

wonday commented Jul 11, 2017

It seems emulator has the problem.
iPhone device will be OK,
can you check it at iPhone?

@opp100
Copy link
Author

opp100 commented Jul 11, 2017

@wonday Hey bro, it is same issue in my iPhone. There are some photo shows the error.

Full document page look like:
dsc_0001

Zoom in a little bit the edge has been cut:
dsc_0002

Zoom in further edge appear again:
dsc_0003

@wonday
Copy link
Owner

wonday commented Jul 11, 2017

Hello @opp100 ,

Thank you for confirming at iPhone,
May be I make some mistake in codes,
Let me check it again.

@opp100
Copy link
Author

opp100 commented Jul 11, 2017

@wonday Appreciate you can still updating this plug-in, I am not familiar with swift thus I cannot work out those stuff by myself. If you can prevent the scrolling down gesture in the first page that will be wonderful. Thanks again.

@wonday
Copy link
Owner

wonday commented Jul 11, 2017

OK, let me try to prevent the scrolling down gesture in first page and scrolling up gesture in last page.

@wonday wonday closed this as completed in 4acdfaa Jul 11, 2017
@wonday
Copy link
Owner

wonday commented Jul 11, 2017

Hi @opp100

I have release v1.2.4 to fix it.
You can test it again.

@wonday wonday reopened this Jul 11, 2017
@opp100
Copy link
Author

opp100 commented Jul 11, 2017

Hey @wonday,

Thanks a lot to fix those issues, everything working perfectly now.

@opp100 opp100 closed this as completed Jul 11, 2017
@Hema2303
Copy link

Hema2303 commented Mar 2, 2018

I having similar issue #137
"react-native-fetch-blob": "^0.10.8",
"react-native-pdf": "^3.0.4",

@wonday @opp100 please help me on this issue

@galo2002
Copy link

galo2002 commented Apr 2, 2018

Same problem here. Pinch zoom doesn't work well on IOS. I'm using same versions as @Hema2303 . Any plans on fixing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants