-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add katex support #75
Conversation
nice work |
change manifest.v2.json
db0a5a2
to
cec41de
Compare
src/manifest.json
Outdated
"web_accessible_resources": [ | ||
{ | ||
"resources": ["fonts/*"], | ||
"matches": ["https://*/*"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
src/styles.css
Outdated
@@ -59,5 +59,5 @@ | |||
|
|||
.chat-gpt-container #answer code { | |||
white-space: pre-wrap; | |||
word-break: break-all; | |||
word-break: break-word; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
'break-all' breaks words, so it might be nicer to use 'break-word'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still considering whether to accept this change, as it increase the installation package from 95K to 1.2M, but not many users will benefit from this feature. |
I optimized the bundle size and now the bundle size is 492KB. |
I decided to not merge this as the use case benefits few users, thanks all the same |
related #71
I added a plugin to markdown-it so that it displays latex formulas, and here are the tests: