Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integer overflow in fb product ID #2825

Open
rawdreeg opened this issue Nov 8, 2024 · 0 comments
Open

Integer overflow in fb product ID #2825

rawdreeg opened this issue Nov 8, 2024 · 0 comments
Labels
type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@rawdreeg
Copy link
Contributor

rawdreeg commented Nov 8, 2024 •
edited
Loading

🔎 Isolate the bug

✍️ Describe the bug

A user reported that the product ID 8643851039008202 returned by FB was being saved as 6.19203E+15 in their store due to a potential integer overflow: https://wordpress.org/support/topic/weird-fb-product-number-contains-a-e-like-a-calculator-error/

They may run on a 32 bit system, but maybe this ID should be explicitly cast as a string to avoid issues like this
@rawdreeg rawdreeg added the type: technical debt This issue/PR represents/solves the technical debt of the project. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rawdreeg