Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font urls not respecting WP_PLUGIN_DIR / WP_PLUGIN_URL #1519

Closed
5 tasks done
ObliviousHarmony opened this issue Oct 26, 2020 · 0 comments · Fixed by #1574
Closed
5 tasks done

Font urls not respecting WP_PLUGIN_DIR / WP_PLUGIN_URL #1519

ObliviousHarmony opened this issue Oct 26, 2020 · 0 comments · Fixed by #1574
Assignees
Labels
category: styles Issues related to styling priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.

Comments

@ObliviousHarmony
Copy link

@GeoJunkie commented on Mon Oct 26 2020

Please provide us with the information requested in this bug report. Without these details, we won't be able to fully evaluate this issue.
Bug reports lacking detail, or for any other reason than to report a bug, may be closed without action.

Prerequisites (mark completed items with an [x]):

  • I have have carried out troubleshooting steps and I believe I have found a bug.
  • I have searched for similar bugs in both open and closed issues and cannot find a duplicate.

Describe the bug
If WP_PLUGIN_DIR and WP_PLUGIN_URL are changed, the imports for @font-face in woocommerce.css are still using the plugins directory. (First reported in the forums)

Expected behavior
The generated CSS should use the configured plugin directory.

Actual behavior
Instead, the src properties point to ../../../../../plugins/, and a 404 error is returned for those fonts.

Steps to reproduce the bug (We need to be able to reproduce the bug in order to fix it.)
Steps to reproduce the bug:

  • Rename plugins folder to modules
  • Add the following directives to wp_config.php (replace yoursite.com with site address):
define( 'WP_PLUGIN_DIR', dirname(__FILE__) . '/wp-content/modules' );
define( 'WP_PLUGIN_URL',  'https://{yoursite.com}/wp-content/modules' );
  • Start/restart the site
  • Navigate to a product page
  • Use the browser inspector to see the error

Screenshots

Screen Shot 2020-10-26 at 10 25 14

Screen Shot 2020-10-26 at 10 25 29

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.

WordPress Environment
We use the WooCommerce System Status Report to help us evaluate the issue.
Without this report we won't be able to fully evaluate this issue.

``` ` ### WordPress Environment ###

WordPress address (URL): https://permalink-test.local
Site address (URL): https://permalink-test.local
WC Version: 4.6.1
REST API Version: ✔ 4.6.1
WC Blocks Version: ✔ 3.4.0
Action Scheduler Version: ✔ 3.1.6
WC Admin Version: ✔ 1.6.2
Log Directory Writable: ✔
WP Version: 5.5.1
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
External object cache: –

Server Environment

Server Info: nginx/1.16.0
PHP Version: 7.3.5
PHP Post Max Size: 1,000 MB
PHP Time Limit: 1200
PHP Max Input Vars: 4000
cURL Version: 7.54.0
LibreSSL/2.6.5

SUHOSIN Installed: –
MySQL Version: 8.0.16
Max Upload Size: 300 MB
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
GZip: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Database

WC Database Version: 4.6.1
WC Database Prefix: wp_
Total Database Size: 3.51MB
Database Data Size: 2.10MB
Database Index Size: 1.41MB
wp_woocommerce_sessions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_order_itemmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_actionscheduler_actions: Data: 0.02MB + Index: 0.11MB + Engine InnoDB
wp_actionscheduler_claims: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_actionscheduler_groups: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_actionscheduler_logs: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_comments: Data: 0.02MB + Index: 0.09MB + Engine InnoDB
wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_options: Data: 1.09MB + Index: 0.03MB + Engine InnoDB
wp_postmeta: Data: 0.13MB + Index: 0.06MB + Engine InnoDB
wp_posts: Data: 0.06MB + Index: 0.06MB + Engine InnoDB
wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_usermeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB
wp_wc_admin_note_actions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wc_admin_notes: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_wc_category_lookup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_wc_customer_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_download_log: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_order_coupon_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_order_product_lookup: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_wc_order_stats: Data: 0.02MB + Index: 0.05MB + Engine InnoDB
wp_wc_order_tax_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_product_meta_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB
wp_wc_reserved_stock: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_wc_tax_rate_classes: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wc_webhooks: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wpfm_backup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB

Post Type Counts

attachment: 24
page: 8
post: 2
product: 18
product_variation: 7
revision: 2

Security

Secure connection (HTTPS): ✔
Hide errors from visitors: ✔

Active Plugins (20)

Query Monitor: by John Blackbourn – 3.6.4
Adjust Curl Options: by @mikkamp – 1.0
Debug Bar Actions and Filters Addon: by Subharanjan – 1.5.4
Debug Bar Console: by koopersmith – 0.3
Debug Bar Constants: by Juliette Reinders Folmer – 2.0.0
Debug Bar Cron: by Zack Tollman
Helen Hou-Sandi – 0.1.2

Debug Bar List Script & Style Dependencies: by Per Soderlind – 1.1
Debug Bar Post Types: by Juliette Reinders Folmer – 2.0.0
Debug Bar Remote Requests: by Matthew Boynes – 0.1.2
Debug Bar Shortcodes: by Juliette Reinders Folmer – 2.0.3
Debug Bar Transients: by Dominik Schilling – 0.5
Debug Bar: by wordpressdotorg – 1.0.1
SQL Executioner: by Justin Watt – 1.4
UpdraftPlus - Backup/Restore: by UpdraftPlus.Com
DavidAnderson – 1.16.31

WooCommerce Sandbox Gateway: by @mikkamp – 1.1 – Installed version not tested with active version of WooCommerce 4.6.1
WooCommerce: by Automattic – 4.6.1
WordPress Admin Style: by Frank Bültge – 1.5.6
WP CLI Login Command Server: by Evan Mattson – 1.2
WP Crontrol: by John Blackbourn & crontributors – 1.8.5
WP File Manager: by mndpsingh287 – 6.9

Inactive Plugins (0)

Settings

API Enabled: –
Force SSL: –
Currency: USD ($)
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Number of Decimals: 2
Taxonomies: Product Types: external (external)
grouped (grouped)
simple (simple)
variable (variable)

Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog)
exclude-from-search (exclude-from-search)
featured (featured)
outofstock (outofstock)
rated-1 (rated-1)
rated-2 (rated-2)
rated-3 (rated-3)
rated-4 (rated-4)
rated-5 (rated-5)

Connected to WooCommerce.com: –

WC Pages

Shop base: #12 - /shop/
Cart: #13 - /cart/
Checkout: #14 - /checkout/
My account: #15 - /my-account/
Terms and conditions: ❌ Page not set

Theme

Name: Storefront
Version: 2.8.0
Author URL: https://woocommerce.com/
Child Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme
WooCommerce Support: ✔

Templates

Overrides: –

Action Scheduler

Complete: 2
Oldest: 2020-10-26 14:02:14 +0000
Newest: 2020-10-26 14:02:14 +0000

`

</details>


@nerrad nerrad added category: styles Issues related to styling type: bug The issue is a confirmed bug. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. labels Jan 5, 2021
@mikejolley mikejolley self-assigned this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: styles Issues related to styling priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants