-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handheld footer bar search - Empty href attribute - Bad for PageSpeed Insights / SEO score #2074
Comments
Hi @Kelderro , Storefront is in maintenance mode and, at least for now, we will not work on this issue. |
Hey @Kelderro, This is what I’ve done: Modify However, keep in mind every time parent theme it’s updated, you got to do it again. Best regards, Mercadearse |
Is your feature request related to a problem? Please describe.
PageSpeed Insights reports the following when the active theme is storefront:
This is caused by the handheld footer bar search. The tag that is used contains an empty href attribute which affect the SEO scoring.
Describe the solution you'd like
There are two solutions to implement this enhancement:
javascript:;
. This can be done by changing line 706 in the storefront-woocommerce-template-functions.php file. From:to
Describe alternatives you've considered
#
. This is not acceptable as this could be a valid link in HTML5.The text was updated successfully, but these errors were encountered: