Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with WooCommerce Blocks, Star Rating Icons Missing #1586

Closed
2 tasks done
JoshuaGoode opened this issue Jan 14, 2021 · 2 comments · Fixed by #1588
Closed
2 tasks done

Conflict with WooCommerce Blocks, Star Rating Icons Missing #1586

JoshuaGoode opened this issue Jan 14, 2021 · 2 comments · Fixed by #1588
Assignees
Labels
category: styles Issues related to styling priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Milestone

Comments

@JoshuaGoode
Copy link

JoshuaGoode commented Jan 14, 2021

Describe the bug

WooCommerce blocks fail to load star rating icons when Storefront is active.

The blocks attempt to load font-family: star; which appears to be available as a .woff, .eot, and .ttf underwp-content/plugins/woocommerce/assets/fonts/

Other themes do not appear to be having issues.

Possible regression related to #1574
cc: @mikejolley @opr @Aljullu

Discussed internally with @GeoJunkie and @fevered.

Isolating the problem:

  • I have deactivated other plugins and themes and confirmed this bug occurs when only WooCommerce + Storefront theme are active.
  • I can reproduce this bug consistently using the steps below.

To Reproduce

Steps to reproduce the behavior:

  1. Create a page using WooCommerce's product blocks.
  2. Ensure at least one product that appears in the block has a rating.
  3. View the front-end of the page.

Screenshots

image

WordPress Environment

Tested across WordPress.com, Pressable, Jurassic Ninja, and SiteGround.

Various infrastructures but all running WooCommerce 4.9 and Storefront 3.3.0

@JoshuaGoode
Copy link
Author

I seem to be missing privileges to add labels within this repo, adding some pings to the original report.

@Aljullu
Copy link
Contributor

Aljullu commented Jan 15, 2021

Thanks for opening this issue @JoshuaGoode!

I can confirm the issue, it seems to affect several blocks:

  • PHP-based product grid blocks:
    imatge
  • All Products block:
    imatge
  • Reviews blocks:
    imatge

Shop page is not affected:
imatge

@Aljullu Aljullu added category: styles Issues related to styling priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. labels Jan 15, 2021
@Aljullu Aljullu added this to the 3.4.0 milestone Jan 15, 2021
@Aljullu Aljullu added the type: bug The issue is a confirmed bug. label Jan 15, 2021
@Aljullu Aljullu self-assigned this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: styles Issues related to styling priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants