Skip to content
This repository was archived by the owner on Jul 12, 2024. It is now read-only.

Add skeleton loading to table summary component #6961

Closed
naman03malhotra opened this issue May 10, 2021 · 1 comment · Fixed by #7294
Closed

Add skeleton loading to table summary component #6961

naman03malhotra opened this issue May 10, 2021 · 1 comment · Fixed by #7294
Assignees
Labels
focus: components Issues for woocommerce components priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@naman03malhotra
Copy link

naman03malhotra commented May 10, 2021

Presently the table summary component does not have a check on the contents of the data object being passed to it. We ran into an issue with the transactions list component in WCPay client where the summary.value is being passed as undefined and it was rendered as-is. One of the ways to solve that was to pass a default value, more details here: Automattic/woocommerce-payments#1639.

However, to maintain consistency with the table component we'd like a similar skeleton loader for the TableSummary as well. Which will be rendered while the data is still being loaded.

It should look something like this

Screenshot 2021-04-23 at 2 47 28 AM

The component will take isLoading as prop which will append a class that will enable skeleton loading animation.

@naman03malhotra naman03malhotra added the focus: components Issues for woocommerce components label May 10, 2021
@naman03malhotra naman03malhotra self-assigned this May 10, 2021
@samueljseay samueljseay added the type: enhancement The issue is a request for an enhancement. label May 13, 2021
@naman03malhotra naman03malhotra added priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. labels May 13, 2021
@htdat htdat self-assigned this Jun 25, 2021
@htdat
Copy link
Contributor

htdat commented Jun 25, 2021

@naman03malhotra - I've done some research on this issue. I will also work on this issue too if you don't mind.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: components Issues for woocommerce components priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants