Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracks: events having an i character are not tracked when using Turkish language #12986

Open
hichamboushaba opened this issue Nov 22, 2024 · 3 comments
Assignees
Labels
category: tracks Related to analytics, including Tracks Events. priority: high Affects lots of customers substantially, but not critically. type: bug A confirmed bug.

Comments

@hichamboushaba
Copy link
Member

hichamboushaba commented Nov 22, 2024

Currently, when the device is using Turkish language, any event that uses the i character will be ignored, because when lowercasing from the enum name, it will be converted to the dottless I.

Currently, the app logs quite a few errors when running, for example:

Cannot create the event: woocommerceandroid_unıfıed_logın_step
com.automattic.android.tracks.Exceptions.EventNameException: Event name must match: ^(([a-z0-9]+)_){2}([a-z0-9_]+)$
@hichamboushaba hichamboushaba added category: tracks Related to analytics, including Tracks Events. priority: high Affects lots of customers substantially, but not critically. type: bug A confirmed bug. labels Nov 22, 2024
@hichamboushaba hichamboushaba self-assigned this Nov 22, 2024
@dangermattic
Copy link
Collaborator

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.

@kidinov
Copy link
Contributor

kidinov commented Nov 22, 2024

Wow, great catch. Looks like It's been there for a long time

I think the same issue is with all locals that based on latine but have some extra characters 🤔

@hichamboushaba
Copy link
Member Author

Wow, great catch. Looks like It's been there for a long time

Yes, probably since the initial implementation 🤷.

I think the same issue is with all locals that based on latine but have some extra characters 🤔

Yes, it's not specific to Turkish, but it was the one that happened to cause an issue with screenshots while led to finding this (p1732209135456889-slack-CGPNUU63E).

My worry is that this issue could be impacting other areas other than tracks, I'm going to post a CUW today to suggest an audit of our usages of the lowercase and uppercase functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. priority: high Affects lots of customers substantially, but not critically. type: bug A confirmed bug.
Projects
None yet
Development

No branches or pull requests

3 participants