-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accessibility in IPP flows #13250
Comments
Thanks for reporting! 👍 |
@malinajirka Can I work on this issue ? |
@Akshaykomar890 Thanks again for your interest in contributing! Feel free to work on this issue, but beware that it likely won't be a simple or a quick one. These flows require quite a bit of setup on both the client as well as the test site. Moreover, there are many different flows (the ones mentioned above are not all the flows that require fixing). These flows are quite prone-to-breaking since the OS runs default animation that can't be easily disabled if dimensions of the dialogs differ even by one pixel, so we need to keep all the dialogs the exact same dimensions. I don't want to discourage you too much, but at the same time I feel it's only fair to warn you about the complexity of this issue. Feel free to work on this one as well as feel free to pick a different one. |
Thank you @malinajirka for the detailed explanation and for taking the time to outline the challenges of this issue. After considering the complexity and my current experience level as a beginner, I believe it would be best for me to start with smaller issues to gain a better understanding of the project. I’ll focus on those first and revisit more complex tasks like this one when I’ve built up more familiarity. Thank you again for your guidance |
Version |
Version |
Version |
Goal of this task is to ensure IPP Flows (payments, welcome, onboarding) work as expected on devices that increase font size using accessibility setting in the OS.
Suggested solution is to wrap the content in a scrollview to at least ensure the widgets don't overlap.
In case, this solution would turn out to have side-effects, we can also consider usingUpdate: We decided this workaround is not acceptable as it's not accessible.dp
instead ofsp
for the texts to at least ensure changing the accessibility setting won't break the layout.The text was updated successfully, but these errors were encountered: