Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against unset. #52

Closed
github-actions bot opened this issue Aug 4, 2022 · 0 comments
Closed

Guard against unset. #52

github-actions bot opened this issue Aug 4, 2022 · 0 comments

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Guard against unset.

woocommerce-blocks-hydration-experiments/src/BlockTypesController.php

Lines 159 to 170 in 8bbbac9

'selector' => $definition['selector'], // TODO: Guard against unset.
'source' => $definition['source'],
);
} else {
if ( array_key_exists( $attr, $block['attrs'] ) ) {
$attributes[ $attr ] = $block['attrs'][ $attr ];
} elseif ( isset( $definition['default'] ) ) {
$attributes[ $attr ] = $definition['default'];
}
}
}
}

🚀 This issue was generated by the automations bot based on a todo comment in 8bbbac9 when #21 was merged. cc @ockham
@luisherranz luisherranz closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luisherranz