Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Enable new notices styles in WooCommerce #12059

Closed
ralucaStan opened this issue Aug 21, 2023 · 6 comments
Closed

Enable new notices styles in WooCommerce #12059

ralucaStan opened this issue Aug 21, 2023 · 6 comments
Assignees
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: cart Issues related to the cart flow focus: checkout Issues related to the checkout flow priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. team: Rubik type: enhancement The issue is a request for an enhancement.

Comments

@ralucaStan
Copy link
Contributor

We updated the buyer notices design. These are currently visible only to the stores that use the Cart/Checkout block;
We need to update the styles of the notices in WC as well, even if the shop is not using the cart and checkout blocks.

related #10641 , #10595, #8659

@nerrad
Copy link
Contributor

nerrad commented Nov 21, 2023

@ralucaStan I don't think the above issues mentioned as blockers are blockers? Will you expand on what they are? I'm going to bump this as a high priority - it still needs to be planned work but it's a visible thing that impacts the coherence of WooCommerce in a block theme.

@nerrad nerrad added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Nov 21, 2023
@ralucaStan
Copy link
Contributor Author

Curently WooCommerce Core inherits the new styles for notices if either the cart or checkout blocks are used, no matter the theme type.

This switch is to ensure the new styles across all WooCommerce. We wanted to make sure we have a public guideline of usage before exposing them to the whole WooCommerce community to ensure alignment across the uses of the notices styles in shops.

See https://woocommerce.github.io/woocommerce-blocks/?path=/docs/base-components-noticebanner--docs and https://woocommerce.github.io/woocommerce-blocks/?path=/docs/base-components-snackbarlist--docs

@ralucaStan
Copy link
Contributor Author

I've removed #10681 from the blockers, as it was closed. Apparently I can't add it back

@nerrad
Copy link
Contributor

nerrad commented Nov 21, 2023

I've removed #10681 from the blockers, as it was closed. Apparently, I can't add it back

I'm confused. That's what we want, 10681 is not a blocker. Neither is #10520 IMO. Irrespective of those issues, we still should roll out the consistency across Woo Core first (regardless of C&C block usage).

@ralucaStan
Copy link
Contributor Author

I've removed them from the blockers and added this ticket to the next cycle.

@nielslange nielslange self-assigned this Dec 4, 2023
@nielslange nielslange added needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. needs: design feedback Issues for which we requested feedback from design team. and removed needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. needs: design feedback Issues for which we requested feedback from design team. labels Dec 4, 2023
@nielslange nielslange transferred this issue from woocommerce/woocommerce-blocks Dec 5, 2023
@nielslange nielslange added type: enhancement The issue is a request for an enhancement. focus: cart Issues related to the cart flow focus: checkout Issues related to the checkout flow block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Dec 5, 2023
@nielslange nielslange transferred this issue from woocommerce/woocommerce Dec 5, 2023
@ObliviousHarmony ObliviousHarmony transferred this issue from woocommerce/woocommerce Dec 5, 2023
@nielslange
Copy link
Member

Closing this as it's a duplicate of #12042, which might have been created by transferring the issue to core and back.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: cart Issues related to the cart flow focus: checkout Issues related to the checkout flow priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. team: Rubik type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants