Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

We don’t have a consistent place to get icons from #1307

Closed
senadir opened this issue Dec 3, 2019 · 1 comment · Fixed by #1644
Closed

We don’t have a consistent place to get icons from #1307

senadir opened this issue Dec 3, 2019 · 1 comment · Fixed by #1644
Assignees
Labels
type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.
Milestone

Comments

@senadir
Copy link
Member

senadir commented Dec 3, 2019

As I was viewing some blocks to see how we call icons, I couldn’t find a consistent method we're following

attribute-filter

import Gridicon from 'gridicons';
src: <Gridicon icon="menus" />,

featured-category

import { IconFolderStar } from '@woocommerce/block-components/icons';
src: <IconFolderStar />,

featured-product

src: 'star-filled',

price-filter

import { IconMoney } from '../../components/icons';
src: <IconMoney />,

I think there is a benefit of tackling this, I see no urgency to it but I'm afraid we will end up with different icons sets moving forward.

@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

@senadir senadir changed the title We don’t a consistent place to get icons from We don’t have a consistent place to get icons from Dec 3, 2019
@nerrad nerrad added type: design type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring. labels Dec 9, 2019
@nerrad nerrad added the type: cooldown Things that are queued for a cooldown period (assists with planning). label Jan 14, 2020
@senadir senadir self-assigned this Jan 24, 2020
@nerrad nerrad added this to the 2.6.0 milestone Jan 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants