Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

[Design] buttons container block? #1886

Closed
strarsis opened this issue Mar 5, 2020 · 4 comments
Closed

[Design] buttons container block? #1886

strarsis opened this issue Mar 5, 2020 · 4 comments
Labels
type: enhancement The issue is a request for an enhancement.

Comments

@strarsis
Copy link
Contributor

strarsis commented Mar 5, 2020

Is your feature request related to a problem? Please describe.
The core/buttons block was added as default container block for inserted core/button blocks.
Some WooCommerce related blocks also use button blocks, however, those are not inside core/buttons container blocks.

Does it make sense to wrap these often singular core/button blocks into a core/buttons container block? Does this core/buttons container block only make sense when an user actually inserts buttons and need some kind of container for the button blocks?

@nerrad
Copy link
Contributor

nerrad commented Mar 7, 2020

Hi there,

I'm not sure exactly what problem you're raising here? From your questions it appears if you are asking about a decision made in Gutenberg core to wrap core/button block into core/buttons containers and whether we think it makes sense? Are you asking if the FeaturedCategory and FeaturedProduct block in this plugin should be using core/buttons instead of core/button?

@strarsis
Copy link
Contributor Author

strarsis commented Mar 7, 2020

@nerrad: Yes, some of these WooCommerce blocks contain core/button blocks.
Does it make sense to wrap them into core/buttons block, too?

@nerrad
Copy link
Contributor

nerrad commented Mar 8, 2020

Whether or not it makes sense depends on what the use case is to have this converted to allow for multiple buttons over a single call to action. I'll leave this issue open for discussion for now, but it's not something I could see us prioritizing at the moment.

@nerrad nerrad added the type: enhancement The issue is a request for an enhancement. label Mar 8, 2020
@nerrad
Copy link
Contributor

nerrad commented Nov 17, 2020

Eventually there will be a refactor of existing Blocks to a new system implementing inner blocks (in the long term roadmap) and when that happens the points raised in this issue likely will be addressed. As is, this is not something explicitly going to be worked on for the existing blocks so I'm going to close this issue.

@nerrad nerrad closed this as completed Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants