Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Navigation: allow adding the Product Search block as a child of the Navigation block #4134

Closed
Aljullu opened this issue Apr 26, 2021 · 7 comments
Closed

Navigation: allow adding the Product Search block as a child of the Navigation block #4134

Aljullu opened this issue Apr 26, 2021 · 7 comments
Labels
block: product search Issues related to the Product Search block. focus: FSE Work related to prepare WooCommerce for FSE. type: enhancement The issue is a request for an enhancement.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Apr 26, 2021 •
edited
Loading

Blocked by WordPress/gutenberg#31387.

The Navigation block included in Gutenberg allows adding the Search block as a child:

imatge

We should allow adding the Product Search block as a child too.

The Product Search block already allows hiding the label, but we might want to import some other options from GB's Search block like changing the button position so it better fits the navigation context (see WordPress/gutenberg#22071).
@Aljullu Aljullu added type: enhancement The issue is a request for an enhancement. block: product search Issues related to the Product Search block. focus: FSE Work related to prepare WooCommerce for FSE. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. labels Apr 26, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 3, 2021
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Sep 3, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Sep 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 3, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jan 3, 2022
@Aljullu Aljullu removed the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Jan 3, 2022
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jan 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 8, 2022
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label May 8, 2022
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label May 16, 2022
@Aljullu
Copy link
Contributor Author

Aljullu commented May 26, 2022

Closing this issue in favor of #6170.

@Aljullu Aljullu closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
block: product search Issues related to the Product Search block. focus: FSE Work related to prepare WooCommerce for FSE. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nerrad @Aljullu