Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product Query: Create All Products variation #6787

Closed
Tracked by #42616
gigitux opened this issue Jul 29, 2022 · 4 comments
Closed
Tracked by #42616

Product Query: Create All Products variation #6787

gigitux opened this issue Jul 29, 2022 · 4 comments
Labels
status: on hold The issue is currently not prioritized or is awaiting something (for example, a fix upsteam). type: new block Applied to work that introduces a new block (typically used on an epic issue).

Comments

@gigitux
Copy link
Contributor

gigitux commented Jul 29, 2022

This issue is blocked by #6795.

The All Products variation has to show all the products, with no further settings besides ordering. This version of the block won't work in tandem with filters.

@gigitux gigitux added the type: new block Applied to work that introduces a new block (typically used on an epic issue). label Jul 29, 2022
@gigitux gigitux changed the title Product Grid: Create All Products variation Product Query: Create All Products variation Aug 5, 2022
@nerrad
Copy link
Contributor

nerrad commented Jan 6, 2023

I think we decide we aren't doing this now? The Products Block is a complete replacement as is?

@gigitux
Copy link
Contributor Author

gigitux commented Jan 9, 2023

I think we decide we aren't doing this now? The Products Block is a complete replacement as is?

Good point! I think that we can close this issue. What do you think, @sunyatasattva?

@sunyatasattva
Copy link
Contributor

The original idea of this block was to have a “setting-less” block which would be easy to just add and avoid all sorts of overwhelming options for the users, making an easy replacement for the “All Products” block and hiding complexity for the very common use-case.

This is currently in the “Icebox” section of woocommerce/woocommerce#42616, I will also add an On Hold label. I think it's premature to close it as we might want to gather a bit of feedback on how the block is used and this might be worthwhile to explore an easy option.

If you folks decide it'd be better to close it, it's ok for me as well, of course.

@sunyatasattva sunyatasattva added the status: on hold The issue is currently not prioritized or is awaiting something (for example, a fix upsteam). label Jan 9, 2023
@nerrad
Copy link
Contributor

nerrad commented Jan 9, 2023

I think we should just close, we can always re-open or create a new issue if feedback comes in warranting a separate block. The description as is, isn't very informative either.

@nerrad nerrad closed this as completed Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: on hold The issue is currently not prioritized or is awaiting something (for example, a fix upsteam). type: new block Applied to work that introduces a new block (typically used on an epic issue).
Projects
None yet
Development

No branches or pull requests

3 participants