Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix Gutenbergs FormTokenField component upstream #6961

Closed
tjcafferkey opened this issue Aug 22, 2022 · 3 comments
Closed

Fix Gutenbergs FormTokenField component upstream #6961

tjcafferkey opened this issue Aug 22, 2022 · 3 comments
Labels
block: filter by attribute Issues related to the Filter by Attribute block. status: stale Stale issues and PRs have had no updates for 60 days. type: bug The issue/PR concerns a confirmed bug. type: cooldown Things that are queued for a cooldown period (assists with planning).

Comments

@tjcafferkey
Copy link
Contributor

Describe the bug

We currently use the <FormTokenField /> component for our dropdown in the Filter by Attribute block. There is an issue whereby when we click "Reset" on the filters we have selected, the dropdown automatically opens. We created a workaround for this to fix it on our end but we need to do an upstream fix for this.

More information can be found on this here #6920 (comment)

To reproduce

Steps to reproduce the behavior:

If this PR is not merged, please checkout the branch instead.

  1. Add Filter by Attribute to a page and ensure its using the dropdown style & has the apply filter button active.
  2. On the frontend, open the dropdown and select an attribute but don't click the "Apply" filter button
  3. Instead click "Reset"
  4. See the dropdown automatically open now.

Expected behavior

On step 4 the dropdown should not open

@tjcafferkey tjcafferkey added type: bug The issue/PR concerns a confirmed bug. type: cooldown Things that are queued for a cooldown period (assists with planning). block: filter by attribute Issues related to the Filter by Attribute block. labels Aug 22, 2022
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Oct 24, 2022
@Aljullu
Copy link
Contributor

Aljullu commented Feb 22, 2023

@tjcafferkey should we close this issue? We will stop using @wordpress/components in the frontend (#8452), so that includes FormTokenField.

@tjcafferkey
Copy link
Contributor Author

Yeah, I think it's safe to close this issue in this case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: filter by attribute Issues related to the Filter by Attribute block. status: stale Stale issues and PRs have had no updates for 60 days. type: bug The issue/PR concerns a confirmed bug. type: cooldown Things that are queued for a cooldown period (assists with planning).
Projects
None yet
Development

No branches or pull requests

2 participants