Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product Query [3]: [FSE] Product Query block should respect catalog visibility options #7645

Closed
Tracked by #42616
sunyatasattva opened this issue Nov 9, 2022 · 2 comments
Labels
block-type: product-query Issues related to/affecting all product-query variations. status: on hold The issue is currently not prioritized or is awaiting something (for example, a fix upsteam). type: bug The issue/PR concerns a confirmed bug.

Comments

@sunyatasattva
Copy link
Contributor

Products can be marked with different visibility options within the admin dashboard:

CleanShot 2022-11-09 at 10 34 13@2x

CleanShot 2022-11-09 at 11 28 27@2x

Currently, the Product Query block doesn't respect this setting, and just shows every product.

image

By default, the Product Query block should respect the visibility options in both FSE templates and other editor context. That means that if a product is set to be “Hidden”, it should not show up even in Product Query blocks used in Posts and Pages. Eventually (issue link TBD) we'll add an option to override this within the inspector, but we'll settle for this default for now.

@sunyatasattva sunyatasattva added type: bug The issue/PR concerns a confirmed bug. block-type: product-query Issues related to/affecting all product-query variations. labels Nov 9, 2022
@sunyatasattva
Copy link
Contributor Author

This will have to be done only if/when we implement the custom “Inherit query from template” logic.

@sunyatasattva sunyatasattva added the status: on hold The issue is currently not prioritized or is awaiting something (for example, a fix upsteam). label Dec 13, 2022
@imanish003
Copy link
Contributor

I checked & found out that when a user has either the Hidden or Search results only options selected, the product won't appear in the Products block. Since we're respecting the catalog visibility option, I am going to close this issue.
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block-type: product-query Issues related to/affecting all product-query variations. status: on hold The issue is currently not prioritized or is awaiting something (for example, a fix upsteam). type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

No branches or pull requests

2 participants