Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product Elements: Add design tools to “On Sale Badge” block #8087

Closed
Tracked by #42616
sunyatasattva opened this issue Jan 3, 2023 · 1 comment · Fixed by #8334
Closed
Tracked by #42616

Product Elements: Add design tools to “On Sale Badge” block #8087

sunyatasattva opened this issue Jan 3, 2023 · 1 comment · Fixed by #8334
Assignees
Labels
block-type: product elements Issues related to Product Element blocks. block-type: product-query Issues related to/affecting all product-query variations. focus: global styles Issues that involve styles/css/layout structure.

Comments

@sunyatasattva
Copy link
Contributor

Details TBD.

cc @vivialice

@sunyatasattva sunyatasattva added focus: global styles Issues that involve styles/css/layout structure. block-type: product elements Issues related to Product Element blocks. block-type: product-query Issues related to/affecting all product-query variations. labels Jan 3, 2023
@vivialice
Copy link

Hey @sunyatasattva 👋

I did a review of the On-Sale badge and you can also find the summary in Figma .We have different settings available depending on where the block is found, either:

  • On the Product image block
  • As its own block
  • In Global styles list

Screenshot 2023-01-18 at 11 16 31

Inspector settings

We already have most of what we need in the separate block variation of On-Sale products. I have a few suggestions for improvement:

  • Bring in other Typography styles available, (right now we are just using Font Size): Font Family, Appearance, Line height, Letter spacing, Letter case, Decoration
  • Add Margin option to Dimensions drawer

Also, I feel like what settings are available in the main panel, should be available in the Global Styles options.

Placement

Screenshot 2023-01-18 at 10 49 50

I am not sure where we ended up on this discussion, but there was talk of exploring referencing the Cover block toolbar placement controls for the product image. For the first iteration, I think it's fine if we continue with the left / center / right options currently available, but perhaps it's something we can explore with this work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block-type: product elements Issues related to Product Element blocks. block-type: product-query Issues related to/affecting all product-query variations. focus: global styles Issues that involve styles/css/layout structure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants