Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Global Styles - Product Title - fix styles application #8662

Open
7 tasks
kmanijak opened this issue Mar 8, 2023 · 0 comments
Open
7 tasks

Global Styles - Product Title - fix styles application #8662

kmanijak opened this issue Mar 8, 2023 · 0 comments
Labels
block-type: product elements Issues related to Product Element blocks. block-type: product-query Issues related to/affecting all product-query variations. focus: global styles Issues that involve styles/css/layout structure. team: Kirigami & Origami type: bug The issue/PR concerns a confirmed bug.

Comments

@kmanijak
Copy link
Contributor

kmanijak commented Mar 8, 2023

Steps to reproduce

  1. Go to Editor
  2. Add Products block
  3. Add Product Title block as an inner block if not already included
  4. Make sure "Make title a link" is enabled
  5. Open Global Styles and change the following styles:

Typography - Text

  • Appearance
    Expected: Assuming the Product Title is a link it should not influence it
    Actual: Only italic is applied, font weight doesn't change

Typography - Links

  • Font
    Expected: Applied in editor and frontend
    Actual: Applied only in editor (frontend doesn't reflect the change)

Typography - Headings

  • Font
  • Size
  • Line height
    Expected: Applied
    Actual: Not applied
  • Appearance
    Expected: Appearance is applied
    Actual: Only italic is applied, font weight doesn't change

Colors - Headings

  • Headings
    Expected: Both background color and text color applies
    Actual: Only background color works

⚠️ Remember

  • Check all of the above in Editor and Frontend!
  • Styles composition may be fragile and the issue may evolve. Please check if block reacts to all the other Global Styles
  • For items we are inheriting from Gutenberg that seem inconsistent and/or have room for improvement, we should raise an upstream Issue or PR and avoid making localized changes that bring inconsistency with Gutenberg.
  • Reflect the newest state of styles support in the Spreadsheet after finishing this task

Note: Technically speaking the Product Title is a heading (H3 by default), so should react to Typography Headings settings. All the expected states above are based on this assumption, however if you think it should not work that way, please update the steps and/or consult with others.

@kmanijak kmanijak added type: bug The issue/PR concerns a confirmed bug. focus: global styles Issues that involve styles/css/layout structure. block-type: product elements Issues related to Product Element blocks. block-type: product-query Issues related to/affecting all product-query variations. labels Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block-type: product elements Issues related to Product Element blocks. block-type: product-query Issues related to/affecting all product-query variations. focus: global styles Issues that involve styles/css/layout structure. team: Kirigami & Origami type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

No branches or pull requests

2 participants