Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[settings] UPE feature flag design update #2063

Closed
frosso opened this issue Oct 8, 2021 · 14 comments · Fixed by #2220
Closed

[settings] UPE feature flag design update #2063

frosso opened this issue Oct 8, 2021 · 14 comments · Fixed by #2220
Assignees
Labels
priority: medium The issue/PR is medium priority—it affects lots of customers substantially, but not critically.

Comments

@frosso
Copy link
Contributor

frosso commented Oct 8, 2021

Description

In the newest designs, it looks like the UPE feature flag changed from being displayed in a banner to being displayed as a chackbox.
(please confirm with UX) checking the checkbox should redirect to the UPE onboarding wizard.

Screen Shot 2021-10-08 at 3 46 48 PM

Questions

  • Does checking the checkbox redirect to the onboarding wizard?
  • Does the redirect happen immediately after saving or immediately after checking it?
    • If it happens immediately after checking the checkbox, is it acceptable to not save the pending changes on the settings?
  • Should we still display a banner in giropay/Sofort/etc. (other UPE payment methods) when UPE is disabled?
  • Should we also remove the inbox notification to enable UPE? (WC_Stripe_UPE_Availability_Note)
  • Any other questions?

Acceptance criteria

  • UX matches the designs
  • Behavior has been clarified
  • Functionality is implemented
@frosso frosso added this to the Finish settings redesign milestone Oct 8, 2021
@cesarcosta99 cesarcosta99 added the needs design The issue requires design input/work from a designer. label Oct 20, 2021
@rafaelzaleski rafaelzaleski self-assigned this Oct 21, 2021
@LevinMedia
Copy link

@frosso @RafaelFunchal

(please confirm with UX) checking the checkbox should redirect to the UPE onboarding wizard.

Affirmative 👍

@frosso
Copy link
Contributor Author

frosso commented Oct 21, 2021

@LevinMedia thanks for confirming!

  • Does the redirect happen immediately after saving or immediately after checking it?
    • If it happens immediately after checking the checkbox, is it acceptable to not save the pending changes on the settings?

@LevinMedia
Copy link

On second thought - that doesn't really make sense, it seems like the first time around it should be a button that launches the experience, then after it's set up, it can be toggled on or off with the check mark - cc @jarekmorawski

@jarekmorawski
Copy link

jarekmorawski commented Oct 22, 2021

@LevinMedia I've thought about it hard while workin on this part of the experience and couldn't figure out how to fit in there a button that would later turn into a checkbox. It seemed logical to me to let folks enable and disable the new experience in exactly the same way. Also, checking a box shows an intent ("I want to enable the new UX") and after the stepper, people will see the end result (the box is checked = the new UX is on).

Given that we've got a more distinguishable button in the Inbox note, I'd stick to the checkbox and add a loader to it so that people know that something's going on in the background when they turn it on.

@frosso
Copy link
Contributor Author

frosso commented Oct 22, 2021

@jarekmorawski it's no problem to convert the experience to a checkbox.
But when does the stepper come into play? Does the user get redirected after checking the checkbox?

If that's the case, are there concerns that the redirect would "break" the user's expectations when checking a checkbox? (i.e.: the user is just checking a checkbox, not clicking on a link)
What would happen to the rest of the settings displayed on the page that haven't yet been persisted? Would it be acceptable to not save the rest of the pending changes on the settings page?

@rafaelzaleski rafaelzaleski removed their assignment Oct 22, 2021
@jarekmorawski
Copy link

Hiya! 👋

Does the user get redirected after checking the checkbox?

That's the idea. Ideally, we'd add a loading state to the checkbox to let them know something's going on in the background. We could let them check the box without going through the setup, but that raises concern that they'd never do it. Without the immediate redirection, we're left with similarly unappealing alternatives:

  • redirecting people after they save settings
  • adding a link/button to the checkbox (what if they miss it?)
  • sending an Inbox note
  • immediately turning on the new UX (without additional config it may break the checkout)

I'm happy to explore it a little further, though. @LevinMedia, do you have any thoughts?

Would it be acceptable to not save the rest of the pending changes on the settings page?

Can they be cached so that changes are visible to people when they finish/cancel UPE setup? Then, they'd proceed to save changes as usually (if people finished setup, UPE would be turned on and saved in the background separately from other settings).

@frosso
Copy link
Contributor Author

frosso commented Nov 5, 2021

Can they be cached so that changes are visible to people when they finish/cancel UPE setup? Then, they'd proceed to save changes as usually (if people finished setup, UPE would be turned on and saved in the background separately from other settings).

The wizard is on a separate page and unfortunately, a page redirect resets the state of a form :(

@jarekmorawski
Copy link

I understand. 🤔 Maybe we could add an affordance to let people know the button is linked to an external flow?

image

cc @LevinMedia

@cesarcosta99
Copy link
Contributor

Jumping in to share an idea, maybe the whole sentence "Try the new checkout experience (early access)" could be a link to the onboarding? Or even turn it into a button? It could be that the user think they just need to tick the box to enable it. We could add a notice/subtitle saying "You will be redirected to the onboarding" or "Your current changes will be discarded" too.

@jarekmorawski can you please share the link we should use for the "submitting your feedback" text?

@jarekmorawski
Copy link

Or even turn it into a button?

That's a great idea and after exploring it a little, David and I arrived at a different, but simpler solution. After checking the box and saving settings (which solves us the "Should we discard changes?" dilemma), we'd show a toast message pointing merchants to Settings > Payments where they'd enable/disable and add payment methods.

We skip the stepper entirely in Stripe, because the payment method are managed differently from WCP.

Here's a brief video of what it'd look like. I'll update the designs in Figma.

toast.mov

@jarekmorawski can you please share the link we should use for the "submitting your feedback" text?

It'd the same CS survey link that we've in Settings > Payments > Payment methods table > Provide feedback:

https://woocommerce.survey.fm/woocommerce-stripe-upe-opt-out-survey

@cesarcosta99
Copy link
Contributor

cesarcosta99 commented Nov 12, 2021

@jarekmorawski I think that really solves most of the questions we had, thank you!

We skip the stepper entirely in Stripe, because the payment method are managed differently from WCP.

That lead us to the remaining questions:

  1. Should we still display a banner in giropay/Sofort/etc. (other UPE payment methods) when UPE is disabled or non-UPE methods such as Alipay?
    image
  2. Should we also remove the inbox notification to enable UPE? (WC_Stripe_UPE_Availability_Note)

If the answer to 1 is "no", it means the onboarding stepper will be completely removed indeed.

@jarekmorawski
Copy link

Hi @cesarcosta99! 👋

Should we still display a banner in giropay/Sofort/etc. (other UPE payment methods) when UPE is disabled or non-UPE methods such as Alipay?

No. I don't think the banner is needed anymore.

Should we also remove the inbox notification to enable UPE? (WC_Stripe_UPE_Availability_Note)

No, I'd leave the notification as it. It currently takes you to the stepper, but now it could enable the UPE in the background and display the toast with a link to the payment methods settings.

image

@cesarcosta99 cesarcosta99 removed the needs design The issue requires design input/work from a designer. label Nov 16, 2021
@cesarcosta99 cesarcosta99 self-assigned this Nov 16, 2021
@dechov
Copy link
Contributor

dechov commented Nov 17, 2021

Will there still be a "Disable" option from the menu of the "Payment methods" view? If so, we may want to word it more clearly: "Disable new checkout experience"?

Also, when disabling using that option, I'm seeing a potentially misleading message about payment methods requiring UPE:

disable-new-checkout-experience

If that will still show, we may want to adjust that wording (though it can also be a separate issue).

@cesarcosta99 cesarcosta99 modified the milestones: Finish settings redesign, New settings post-release Nov 18, 2021
@jarekmorawski
Copy link

Will there still be a "Disable" option from the menu of the "Payment methods" view?

Yup! In Stripe, the message has been tweaked a little.

image

@cesarcosta99 cesarcosta99 added the priority: medium The issue/PR is medium priority—it affects lots of customers substantially, but not critically. label Nov 23, 2021
@cesarcosta99 cesarcosta99 linked a pull request Dec 8, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium The issue/PR is medium priority—it affects lots of customers substantially, but not critically.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants