Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pay Later messaging configurator sometimes displays old settings after saving (3139) #2249

Merged
merged 1 commit into from
May 22, 2024
Merged

Pay Later messaging configurator sometimes displays old settings after saving (3139) #2249

merged 1 commit into from
May 22, 2024

Conversation

danieldudzic
Copy link
Collaborator

Description

This PR fixes the issue with PayLater Configurator settings not loading the updated values on reload after saving.

The issue has been addressed by introducing a custom endpoint for fetching the config data on the client side.

Steps to Test

  1. Open the Pay Later tab in the PayPal Settings.
  2. Test enabling/disabling various Pay Later configuration options and saving them.
  3. Confirm that post-save (after the page reload) the Pay Later configuration reflects the most recent changes.

Screenshots

Before After
before-ezgif com-video-to-gif-converter after-ezgif com-video-to-gif-converter

@InpsydeNiklas InpsydeNiklas added the bug Something isn't working label May 22, 2024
@InpsydeNiklas InpsydeNiklas changed the title Pay Later Configurator: Fix settings saving (3139) Pay Later messaging configurator sometimes displays old settings after saving (3139) May 22, 2024
@Dinamiko Dinamiko merged commit d95adc6 into trunk May 22, 2024
9 checks passed
@Dinamiko Dinamiko deleted the PCP-3139-improve-loading-saved-settings-in-pay-later-messaging-configurator branch May 22, 2024 10:46
@Dinamiko Dinamiko added this to the 2.7.1 milestone May 22, 2024
@Dinamiko Dinamiko mentioned this pull request May 22, 2024
Merged
This was linked to issues May 22, 2024
Remove Pay Later Messaging - Settings not saving #2 #2243
Closed
Impossible to customize Pay Later Messaging (3139) #2261
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinamiko Dinamiko Dinamiko approved these changes

@InpsydeNiklas InpsydeNiklas Awaiting requested review from InpsydeNiklas

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.7.1
Development

Successfully merging this pull request may close these issues.

Impossible to customize Pay Later Messaging (3139) Remove Pay Later Messaging - Settings not saving #2
3 participants
@danieldudzic @Dinamiko @InpsydeNiklas