Product Query [4]: Implement layout options

[sunyatasattva]

This is a placeholder issue for when the spec of the layout options is finalized.

FIgma Design: UmuaN1XXqCa6myOHkb0ZWy-fi-1207%3A116374&t=a12roEsuCt8ErZjq-0

Note that ideally, this layout panel will be integrated with the existing one where needed. Since this is currently not possible in Gutenberg, hacky solutions like CSS hiding are allowed as per this comment (pdnLyh-30z-p2#comment-1948).

Whether settings should be duplicated in the toolbar and inspector controls, or only implemented in the inspector controls it's still a decision to be made.

cc @vivialice

[imanish003]

Hi @sunyatasattva,

FIgma Design: UmuaN1XXqCa6myOHkb0ZWy-fi-1207%3A116374&t=a12roEsuCt8ErZjq-0

As the link was not working for me, so adding following screenshot for further reference:

Since this is currently not possible in Gutenberg, hacky solutions like CSS hiding are allowed as per this comment (pdnLyh-30z-p2#comment-1948).

Does this mean that we can hide existing Layout panel & then add a new Layout option?

---

Also, I can see that you have this PR on woocommerce-blocks repo & this PR for Gutenberg repo. But I don't see any discussion on both of these PRs. Because of this I have 2 queries:

• Are we planning to merge these PRs soon? Is there any discussion going on around these PRs?
• Should I wait for these PRs to merge or start working on the hacky CSS solution?

[sunyatasattva]

Hello @imanish003

This one is a hard topic. The main discussion is here: https://github.com/woocommerce/woocommerce-blocks/discussions/8276

But since then, these PRs have been referenced a bunch of times honestly. Once I can remember off the top of my head is in this conversation: https://wp.me/per0F9-ns

But maybe you'll find also more things in the PT comments. I believe in any case that we require alignment with Gutenberg. So perhaps the conversation can be continued in the GitHub discussion thread?

[imanish003]

Hi @sunyatasattva,
As per the discussion in P2s, it Looks like this won't be implemented in Gutenberg anytime soon.

Note that ideally, this layout panel will be integrated with the existing one where needed. Since this is currently not possible in Gutenberg, hacky solutions like CSS hiding are allowed as per this comment (pdnLyh-30z-p2#comment-1948).

As mentioned in the issue description. Should we consider using CSS to hide the existing layout panel?
OR
Maybe we can keep the existing layout panel and add a new section for our layout options? Although it doesn't make sense to keep the existing layout panel as it is not very useful. What do you think?

[sunyatasattva]

Hey @imanish003 ! I think at this point the best would be to discuss it with design and get Jarek up to speed on this perhaps. So that we don't do something that's unaligned with GB again.

[imanish003]

Thanks for the suggestion, @sunyatasattva. 🙌🏻 I agree that it would be good to have a discussion with design and Jarek to ensure that we align with GB. 🤝 I'll reach out to them and see if we can schedule a meeting to discuss the options and decide on the best approach.

I noticed that you have created a PR on the GB repo. I will try to keep in sync with interesting discussions going on there. 🤝