Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help color blind people by changing dots to icons #1393

Closed
3 tasks done
gapodo opened this issue Nov 3, 2022 · 5 comments · Fixed by #1409
Closed
3 tasks done

Help color blind people by changing dots to icons #1393

gapodo opened this issue Nov 3, 2022 · 5 comments · Fixed by #1409
Labels
enhancement improve existing features ui frontend related ux user experience
Milestone

Comments

@gapodo
Copy link
Contributor

gapodo commented Nov 3, 2022

Clear and concise description of the problem

As a colorblind user, it is difficult for me to see the status of steps in pipelines.

Suggested solution

Change the colored dot in the web-ui over to an icon. We could possibly reuse the icons used to display the status in the workflow view.

The colored dot in question:
image

This is the icon I think we could use (of course "all of them" depending on status).
image

Alternative

Other icons or leave it be? It's not a huge inconvenience (though I'm not fully colorblind)

Additional context

No response

Validations

@gapodo
Copy link
Contributor Author

gapodo commented Nov 3, 2022

also tagging #1314 as this would be a UI improvement / feedback

@altdsoy
Copy link

altdsoy commented Nov 3, 2022

Couldn't agree more with a16y improvements!

@qwerty287 qwerty287 added ui frontend related enhancement improve existing features and removed pending:feature labels Nov 5, 2022
@anbraten
Copy link
Member

anbraten commented Nov 5, 2022

Thanks for this helpful feedback.

Linking #959

@6543 6543 added the ux user experience label Nov 6, 2022
@gapodo
Copy link
Contributor Author

gapodo commented Nov 9, 2022

@anbraten Just as a follow-up since I am unsure if / where we should document it, a very good simulation is available at https://www.color-blindness.com/coblis-color-blindness-simulator/ (it requires uploading as an image, but unlike others has very solid results). We tested 2 of the 3 (main) simulations, with me, Protanopia and a friend Tritanopia, and a "full color capable" 3rd party (on a multitude of images), and the results produced are fairly close to what we see (i.e. we thought our respective simulation is identical or just a bit brighter / darker than the original) and the "normal vision" person was shocked.

If there is a need for a tested (chrome / firefox) add-on I could see about getting together and testing one, so we would have a reference for people that don't know how colors can impact the UX of a UI, that works on the fly

Edit: just found the second page we were using (and verifies) which was https://www.toptal.com/designers/colorfilter which takes an URL

@anbraten
Copy link
Member

anbraten commented Nov 9, 2022

I guess best option longterm would be to have a check as part of the CI 🤩. Testing it manually requires some time and therefore would be to much to ask every UI developer to do. We could create a section in the docs in the development section noting some useful tools like the ones you suggested, so someone could check from time to time.

@6543 6543 added this to the 1.0.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features ui frontend related ux user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants