Wrong pipeline status

[xoxys]

Component

server

Describe the bug

Pipeline status for cancelled pipeline is wrong:

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-63d5c40a"}

### Additional context

_No response_

### Validations

- [X] Read the [Contributing Guidelines](https://github.com/woodpecker-ci/woodpecker/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://woodpecker-ci.org/docs/intro).
- [X] Check that there isn't [already an issue](https://github.com/woodpecker-ci/woodpecker/issues) that reports the same bug to avoid creating a duplicate.
- [X] Checked that the bug isn't fixed in the `next` version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
- [X] Check that this is a concrete bug. For Q&A join our [Discord Chat Server](https://discord.gg/fcMQqSMXJy) or the [Matrix room](https://matrix.to/#/#woodpecker:matrix.org).

[pat-s]

related #1871 #1893

[xoxys]

It gets even worse. Even if the pipeline status is correct in the UI, CI_PIPELINE_STATUS is wrong, which makes it pretty useless to use for notifications 🙈

while CI_PIPELINE_STATUS has reported success during a notification step

[anbraten]

Maybe related. Pipeline is already show as error, but is still running and no steps has an error 🤔
https://ci.woodpecker-ci.org/repos/3780/pipeline/9551

[anbraten]

Step failed, but pipeline was marked as successful: https://ci.woodpecker-ci.org/repos/3780/pipeline/13542

[anbraten]

Found another interesting status mismatch: https://ci.woodpecker-ci.org/repos/3780/pipeline/14498

[anbraten]

I think this line could be the issue:

woodpecker/agent/runner.go

Line 168 in 2bda190

state.Error = ""

In case of a canceled workflow the error is set to "" (no error). The configured exit code doesn't seem to be considered by any logic at all and is only used for logging: #3848