-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "meta" workflow for matrix workflows, to have easy status check rules #2886
Comments
I guess related PR is #2695 |
This is kind of hard to do internally, because every matrix axis is a workflow and workflows have a separated status. |
Understandable, but IMO this really makes it quite useless if you need to enforce those checks to pass. While I build and test tool today for python3.10, 3.11 and 3.12 I might add python-nightly tomorrow and remove 3.10 a few days later. Adjusting the forge settings every time the matrix changes doesn't scale at least not for me. |
I see the issue, but I'm not sure about a good way how to implement this cleanly. I can take a look at it though if I find the time... |
Thanks dont wanted to rush you or anybody else. |
I propose (if not already done so) a "meta" pipeline that collect all matrix status and if one fails it is failed, else it is passed. this is reported back so you can set that one as required. for gitea you can just specify a regex in recent versions :) |
Component
server
Describe the bug
With v2.0 the behavior of matrix workflows has changes. Instead of a single
ci/woodpecker/pr/test
check, multipleci/woodpecker/pr/test/<NUMBER>
checks are reported now, one for each item in the matrix. As a result, existing rules for required status checks in the forge are broken, which also affects all automations bases on successful status checks.IMO there should be a single check again instead of dedicated checks for each matrix element. A matrix can be dynamic (frequent changes to the number of elements) which makes it nearly impossible to enforce it.
System Info
Additional context
No response
Validations
next
version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]The text was updated successfully, but these errors were encountered: