Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX: Apply Non-Empty Environment Variables #3292

Closed
3 tasks done
HerHde opened this issue Jan 29, 2024 · 0 comments · Fixed by #3314
Closed
3 tasks done

UI/UX: Apply Non-Empty Environment Variables #3292

HerHde opened this issue Jan 29, 2024 · 0 comments · Fixed by #3314
Assignees
Labels
enhancement improve existing features ui frontend related ux user experience

Comments

@HerHde
Copy link
Contributor

HerHde commented Jan 29, 2024

Clear and concise description of the problem

When triggering a manual pipeline run in the web UI, I often forget to apply env vars with the + Add variable button, as I interpret it as adding another variable.

image

Suggested solution

  • Apply all variables with non-empty variable names
  • Add a new input line once the variable name is not empty
  • Keep the variables editable
  • Remove the + Add variable button

Example from GitLab:

image

Alternative

No response

Additional context

Might also be useful if my issue #3291 gets implemented

Validations

  • Checked that the feature isn't part of the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@HerHde HerHde added the feature add new functionality label Jan 29, 2024
@qwerty287 qwerty287 added ui frontend related enhancement improve existing features ux user experience and removed feature add new functionality labels Jan 29, 2024
@lukashass lukashass self-assigned this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features ui frontend related ux user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants