Rework pipeline messages #4626
Rework pipeline messages #4626
Conversation
qwerty287
added
the
breaking
|
@qwerty287 Why is that breaking? Because of the env var change? |
|
Yes, env var change and it also changes the json for the pipeline model |
|
@xoxys updated the description |
|
Thank you! ❤️ |
|
Will finally take a look this evening. |
This comment was marked as resolved.
This comment was marked as resolved.
|
I would stick to a two line layout, even if the second line would be empty. The pipeline id is not show for me. |
I'm not sure if I'd do this.
This looks kinda weird.
This is very weird, as it seems to be a problem in the migration. However, I couldn't find the bug in the code, everything seems correct… |
qwerty287
force-pushed
the
pl-commit-pr
branch
from
b1c830f to
11866b4
Compare
True. But I would prefer to not change the layout depending on the event. Ill try to find another approach if not Im also fine with the current way. |
| @@ -364,22 +364,28 @@ func (c *client) BranchHead(ctx context.Context, u *model.User, r *model.Repo, b | |||
| if err != nil { | |||
| return nil, fmt.Errorf("unable to create bitbucket client: %w", err) | |||
| } | |||
| branches, _, err := bc.Projects.SearchBranches(ctx, r.Owner, r.Name, &bb.BranchSearchOptions{Filter: b}) | |||
| commits, _, err := bc.Projects.SearchCommits(ctx, r.Owner, r.Name, &bb.CommitSearchOptions{ | |||
There was a problem hiding this comment.
I'll see if I can do this API call to Bitbucket to verify that the Until property actually returns what we expect. The b variable will contain the branch name not the ref?
There was a problem hiding this comment.
Yes, it's just the branch name.
|
@langecode thank you very much for your comments. Can you also check out this? |
|
Didn’t get around to this before starting 3 weeks of vacationing - but I
did a little digging when I remembered your message. The link is somewhat
along the pattern - the “at” parameter should be good for both refs and
tags (like at=refs%2Ftags%2Fmytag)
https://
<base>/projects/<project>/repos/<repo>/browse?at=refs%2Fheads%2Frenovate%2Fconfigure
There is some mentions of problems with slash in branch names so the
url-encode of the value may be important. I copied the above from the UI in
a working Bitbucket for branch “renovate/configure” so it is confirmed -
also checked a tag.
tors. 23. jan. 2025 kl. 16.07 skrev qwerty287 ***@***.***>:
… @langecode <https://github.com/langecode> thank you very much for your
comments. Can you also check out this?
https://github.com/woodpecker-ci/woodpecker/blob/7803d4852ed6c5bb5b909c1a3e109052dafa2c42/server/forge/bitbucketdatacenter/convert.go#L100
—
Reply to this email directly, view it on GitHub
<#4626 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJPWOS6XTX34AK6OVZSO4L2MDSS5AVCNFSM6AAAAABUIO2GPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBZG43DKNZXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
supersedes #3421
closes #2971
closes #4677
closes #4195
Currently, our pipeline model has fields like the message, title etc., but every field is used differently, dependending on the event.
This PR changes this and splits these reused fields to have a more clear pipeline model.
The model now has fields like:
and similar.
Advantages:
Especially 3 and 4 and are the enhancement parts here, as we can now store both context and commit message and not only one.
new UI for a PR:
TODO