Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename build to pipeline in bagde #955

Closed
3 tasks done
x80486 opened this issue Jun 3, 2022 · 3 comments · Fixed by #956
Closed
3 tasks done

Rename build to pipeline in bagde #955

x80486 opened this issue Jun 3, 2022 · 3 comments · Fixed by #956
Labels
enhancement improve existing features good first issue Likely to be an easy fix
Milestone

Comments

@x80486
Copy link

x80486 commented Jun 3, 2022

Clear and concise description of the problem

This one falls into a very gray area, but I think the build | status badge could be more generic and be presented as pipeline | status, because build is a targeted process within the entire pipeline — if present.

Some pipelines don't have a "build" process, but like I said, it's a grays area, because the word can be used to describe the entire process as well.

Suggested solution

Badge should be pipeline | status.

Alternative

N/A

Additional context

N/A

Validations

@6543 6543 added enhancement improve existing features good first issue Likely to be an easy fix and removed pending:feature labels Jun 3, 2022
@6543 6543 added this to the 1.0.0 milestone Jun 3, 2022
@anbraten
Copy link
Member

anbraten commented Jun 3, 2022

I am a fan of the word pipeline instead of build as well. My plan would be to get rid of the build term completely at some point.

See #949 (comment) and #745

@anbraten anbraten changed the title Build bagde could be more generic Rename build to pipeline in bagde Jun 3, 2022
@x80486
Copy link
Author

x80486 commented Jun 3, 2022

Damn...I didn't see the other issue 😬

Should we close this one instead? Probably adding something else to the other one?

@anbraten
Copy link
Member

anbraten commented Jun 3, 2022

We can leave it open. Could you create a pull-request to change the naming. It shoulb be just the following four lines: https://github.com/woodpecker-ci/woodpecker/blob/master/server/badges/badges.go#L20-L24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features good first issue Likely to be an easy fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants