Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching: persist between runs #52

Closed
woodruffw opened this issue Oct 27, 2024 · 2 comments · Fixed by #304
Closed

Caching: persist between runs #52

woodruffw opened this issue Oct 27, 2024 · 2 comments · Fixed by #304
Assignees
Labels
enhancement New feature or request performance
Milestone

Comments

@woodruffw
Copy link
Owner

Right now we cache GitHub API responses between audits/workflows, but there are a lot of responses that also make sense to cache between zizmor runs (e.g. a commit that isn't an impostor isn't going to become an impostor).

@woodruffw woodruffw added enhancement New feature or request performance labels Oct 27, 2024
@woodruffw woodruffw self-assigned this Oct 27, 2024
@woodruffw
Copy link
Owner Author

Thinking about this more: I think almost all of the caching can be moved into HTTP middleware, since nothing else we do is really that expensive (or more precisely, so expensive that it makes sense to cache between runs).

For HTTP caching, this looks promising: https://github.com/06chaynes/http-cache/tree/main/http-cache-reqwest

@woodruffw
Copy link
Owner Author

#304 is an attempt at the above.

@woodruffw woodruffw added this to the 1.0 milestone Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant