We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When the Arrange in Grid component tries to run with an input of "0" for Rows, the component freezes with no recovery (escape behavior) possible.
To recreate the bug: add a valid input to the "G" input of the component. add a 0 or negative number it the "I" input.
In the code for this component, (https://github.com/woodsbagot/WombatGH/blob/master/WombatGH/ArrangeInGrid.cs) it looks like the problem is that the for loop has escape behavior for 0 and negative values, but the while loop does not handle the condition where the for loop ends while the geoToTransform list still has items in it.
There are a few ways I can think of to solve this - set a minimum value of one for rowCount, add an error for ineligible values for rowCount, or add escape behavior for the loop (http://james-ramsden.com/you-should-be-implementing-esc-behaviour-in-your-grasshopper-development/). Don't know which one is most in keeping with the strategy of the WB code keepers.
Thanks!
The text was updated successfully, but these errors were encountered:
No branches or pull requests
When the Arrange in Grid component tries to run with an input of "0" for Rows, the component freezes with no recovery (escape behavior) possible.
To recreate the bug:
add a valid input to the "G" input of the component.
add a 0 or negative number it the "I" input.
In the code for this component, (https://github.com/woodsbagot/WombatGH/blob/master/WombatGH/ArrangeInGrid.cs) it looks like the problem is that the for loop has escape behavior for 0 and negative values, but the while loop does not handle the condition where the for loop ends while the geoToTransform list still has items in it.
There are a few ways I can think of to solve this - set a minimum value of one for rowCount, add an error for ineligible values for rowCount, or add escape behavior for the loop (http://james-ramsden.com/you-should-be-implementing-esc-behaviour-in-your-grasshopper-development/). Don't know which one is most in keeping with the strategy of the WB code keepers.
Thanks!
The text was updated successfully, but these errors were encountered: