Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getBalances doc is not correct #177

Closed
opx221 opened this issue Jan 27, 2024 · 2 comments
Closed

getBalances doc is not correct #177

opx221 opened this issue Jan 27, 2024 · 2 comments

Comments

@opx221
Copy link

opx221 commented Jan 27, 2024

hello

getBalances doc says "Get the locked and unlocked balances in a single request.", but it returns (total) balance, not locked balance
I think it can be changed to just "Get the balance and unlocked balance in a single request."

@woodser
Copy link
Owner

woodser commented Jan 27, 2024

Only the RPC wallet supports getBalances(), which returns an array with the total balance and unlocked balance.

I ran a quick test to ensure it's returning an array as expected.

@woodser
Copy link
Owner

woodser commented Apr 2, 2024

Ah I just realized what you were saying, with the documentation being incorrect.

Fixed in e84126a.

Thanks.

@woodser woodser closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants