Fix bug where blockquotes had trailing spaces

remarkjs · Dec 24, 2015 · a51f112 · a51f112
1 parent 33752f4
commit a51f112
Show file tree

Hide file tree

Showing 3 changed files with 110 additions and 2 deletions.
diff --git a/lib/stringify.js b/lib/stringify.js
@@ -1242,9 +1242,18 @@ compilerPrototype.paragraph = function (node) {
  * @return {string} - Markdown block quote.
  */
 compilerPrototype.blockquote = function (node) {
-    var indent = ANGLE_BRACKET_CLOSE + SPACE;
+    var values = this.block(node).split(LINE);
+    var result = [];
+    var length = values.length;
+    var index = -1;
+    var value;
+
+    while (++index < length) {
+        value = values[index];
+        result[index] = (value ? SPACE : EMPTY) + value;
+    }
 
-    return indent + this.block(node).split(LINE).join(LINE + indent);
+    return ANGLE_BRACKET_CLOSE + result.join(LINE + ANGLE_BRACKET_CLOSE);
 };
 
 /**

diff --git a/test/input/blockquotes-empty-lines.output.text b/test/input/blockquotes-empty-lines.output.text
@@ -0,0 +1,3 @@
+> Note there is no space on the following line.
+>
+> Note there is no space on the preceding line.
diff --git a/test/tree/blockquotes-empty-lines.output.json b/test/tree/blockquotes-empty-lines.output.json
@@ -0,0 +1,96 @@
+{
+  "type": "root",
+  "children": [
+    {
+      "type": "blockquote",
+      "children": [
+        {
+          "type": "paragraph",
+          "children": [
+            {
+              "type": "text",
+              "value": "Note there is no space on the following line.",
+              "position": {
+                "start": {
+                  "line": 1,
+                  "column": 3
+                },
+                "end": {
+                  "line": 1,
+                  "column": 48
+                },
+                "indent": []
+              }
+            }
+          ],
+          "position": {
+            "start": {
+              "line": 1,
+              "column": 3
+            },
+            "end": {
+              "line": 1,
+              "column": 48
+            },
+            "indent": []
+          }
+        },
+        {
+          "type": "paragraph",
+          "children": [
+            {
+              "type": "text",
+              "value": "Note there is no space on the preceding line.",
+              "position": {
+                "start": {
+                  "line": 3,
+                  "column": 3
+                },
+                "end": {
+                  "line": 3,
+                  "column": 48
+                },
+                "indent": []
+              }
+            }
+          ],
+          "position": {
+            "start": {
+              "line": 3,
+              "column": 3
+            },
+            "end": {
+              "line": 3,
+              "column": 48
+            },
+            "indent": []
+          }
+        }
+      ],
+      "position": {
+        "start": {
+          "line": 1,
+          "column": 1
+        },
+        "end": {
+          "line": 3,
+          "column": 48
+        },
+        "indent": [
+          1,
+          1
+        ]
+      }
+    }
+  ],
+  "position": {
+    "start": {
+      "line": 1,
+      "column": 1
+    },
+    "end": {
+      "line": 4,
+      "column": 1
+    }
+  }
+}