feat: ResponseEntity 에 redirect 메서드 생성

Author: BGuga

tomcat/src/main/java/org/apache/coyote/http11/controller/LoginController.java

@@ -24,9 +24,7 @@ public LoginController(LoginService loginService) {
     @Override
     public ResponseEntity<? extends Object> doGet(HttpRequest httpRequest) {
         if (SessionManager.loggedIn(httpRequest)) {
-            return ResponseEntity.status(302)
-                .addHeader(LOCATION_HEADER, INDEX_PAGE)
-                .build();
+            return ResponseEntity.redirect(INDEX_PAGE);
         }
         ResponseEntity<Object> responseEntity = ResponseEntity.status(200).build();
         responseEntity.responseView("/login.html");
@@ -36,9 +34,7 @@ public ResponseEntity<? extends Object> doGet(HttpRequest httpRequest) {
     @Override
     public ResponseEntity<? extends Object> doPost(HttpRequest httpRequest) {
         if (SessionManager.loggedIn(httpRequest)) {
-            return ResponseEntity.status(302)
-                .addHeader(LOCATION_HEADER, INDEX_PAGE)
-                .build();
+            return ResponseEntity.redirect(INDEX_PAGE);
         }
 
         Optional<String> loginSession = login(httpRequest);
@@ -49,9 +45,7 @@ public ResponseEntity<? extends Object> doPost(HttpRequest httpRequest) {
                 .build();
         }
 
-        return ResponseEntity.status(302)
-            .addHeader(LOCATION_HEADER, "/401.html")
-            .build();
+        return ResponseEntity.redirect("/401.html");
     }
 
     private Optional<String> login(HttpRequest httpRequest) {
@@ -66,13 +60,11 @@ private Optional<String> login(HttpRequest httpRequest) {
 
     @Override
     public ResponseEntity<? extends Object> doPut(HttpRequest httpRequest) {
-        return ResponseEntity.status(405)
-            .build();
+        return ResponseEntity.notAllowed();
     }
 
     @Override
     public ResponseEntity<? extends Object> doDelete(HttpRequest httpRequest) {
-        return ResponseEntity.status(405)
-            .build();
+        return ResponseEntity.notAllowed();
     }
 }

tomcat/src/main/java/org/apache/coyote/http11/controller/SignUpController.java

@@ -25,9 +25,7 @@ public SignUpController(LoginService loginService) {
     @Override
     public ResponseEntity<? extends Object> doGet(HttpRequest httpRequest) {
         if (SessionManager.loggedIn(httpRequest)) {
-            return ResponseEntity.status(302)
-                .addHeader(LOCATION_HEADER, INDEX_PAGE)
-                .build();
+            return ResponseEntity.redirect(INDEX_PAGE);
         }
         ResponseEntity<Object> responseEntity = ResponseEntity.status(200).build();
         responseEntity.responseView("/register.html");
@@ -38,19 +36,15 @@ public ResponseEntity<? extends Object> doGet(HttpRequest httpRequest) {
     public ResponseEntity<? extends Object> doPost(HttpRequest httpRequest) {
         try {
             if (SessionManager.loggedIn(httpRequest)) {
-                return ResponseEntity.status(302)
-                    .addHeader(LOCATION_HEADER, INDEX_PAGE)
-                    .build();
+                return ResponseEntity.redirect(INDEX_PAGE);
             }
             String loginSession = signUp(httpRequest);
             return ResponseEntity.status(302)
                 .addHeader(LOCATION_HEADER, INDEX_PAGE)
                 .addHeader("Set-Cookie", "JSESSIONID" + "=" + loginSession)
                 .build();
         } catch (MemberAlreadyExistsException e) {
-            return ResponseEntity.status(302)
-                .addHeader(LOCATION_HEADER, "/register.html")
-                .build();
+            return ResponseEntity.redirect("/register.html");
         }
     }
 
@@ -64,13 +58,11 @@ private String signUp(HttpRequest httpRequest) {
 
     @Override
     public ResponseEntity<? extends Object> doPut(HttpRequest httpRequest) {
-        return ResponseEntity.status(405)
-            .build();
+        return ResponseEntity.notAllowed();
     }
 
     @Override
     public ResponseEntity<? extends Object> doDelete(HttpRequest httpRequest) {
-        return ResponseEntity.status(405)
-            .build();
+        return ResponseEntity.notAllowed();
     }
 }

tomcat/src/main/java/org/apache/coyote/http11/response/ResponseEntity.java

@@ -21,6 +21,16 @@ public static ResponseBuilder status(int statusCode) {
         return new ResponseBuilderImpl(statusCode);
     }
 
+    public static ResponseEntity<Object> redirect(String path) {
+        Map<String, String> headers = new HashMap<>();
+        headers.put("Location", path);
+        return new ResponseEntity<>(302, headers, null);
+    }
+
+    public static ResponseEntity<Object> notAllowed() {
+        return new ResponseEntity<>(405, null, null);
+    }
+
     public void responseView(String viewPath) {
         this.viewResponse = true;
         this.viewPath = viewPath;