[JDBC 라이브러리 구현하기 - 1단계] 허브(방대의) 미션 제출합니다. #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junpakPark
reviewed
Sep 26, 2023
|
|
||
| public <T> T queryForObject(final String sql, final RowMapper<T> rowMapper, final Object... parameters) { | ||
| try (final Connection connection = dataSource.getConnection(); | ||
| final PreparedStatement preparedStatement = getPreparedStatement(sql, connection, parameters); |
This2sho
approved these changes
Sep 30, 2023
|
|
||
| ### 1단계 - JDBC 라이브러리 구현하기 | ||
|
|
||
| - [x] RowMapper 인터페이스를 추가한다. |
There was a problem hiding this comment.
!!
허브는 기능 명세 작성할 때부터 RowMapper를 사용해야겠다는 걸 알고 계셨나요?!
(저는 처음에 Reflection으로 sql의 파라미터수에 맞는 생성자를 찾아서 일일히 타입 맞춰서 넣어주는 건 줄 알고..;; ㅋ)
There was a problem hiding this comment.
아하 예전에 체스 미션할 때 JdbcTemplate을 간단하게 만들어본 적이 있어서 기억이 났어요!
| } | ||
|
|
||
| public void update(final User user) { | ||
| // todo | ||
| final String sql = "update users set (account, password, email) = (?, ?, ?) where id = ?"; |
|
|
||
| public <T> T queryForObject(final String sql, final RowMapper<T> rowMapper, final Object... parameters) { | ||
| try (final Connection connection = dataSource.getConnection(); | ||
| final PreparedStatement preparedStatement = getPreparedStatement(sql, connection, parameters); |
| if (resultSet.next()) { | ||
| return rowMapper.mapRow(resultSet); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
일단 UserDaoTest를 수정하지 않고 동작하게 하려고 null을 반환시켰습니다!
null을 반환하기 보다 사용하는 쪽에서 조금 더 명확하게 처리할 수 있도록, 이 부분은 2단계 제출하면서 Optional을 반환하는 방향으로 수정해볼게요!!
| import java.sql.ResultSet; | ||
| import java.sql.SQLException; | ||
|
|
||
| @FunctionalInterface |
| final ResultSet resultSet = preparedStatement.executeQuery()) { | ||
| log.debug("query : {}", sql); | ||
| if (resultSet.next()) { | ||
| return rowMapper.mapRow(resultSet); |
There was a problem hiding this comment.
하나면 조회 결과 중 제일 처음 부분만 반환될 것 같습니다!
이 부분도 조회 결과가 2개 이상이라면 예외를 던지도록 수정해볼게요 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 호이!
미션 간단하게 진행해보았습니다!
간단하게 JdbcTemplate으로 코드를 이동시켜보았습니다!
이번 미션 잘 부탁드립니다! 👍
리뷰 범위는 다음과 같습니다.
리뷰 범위