Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MVC 구현하기 - 1단계] 레넌(조형래) 미션 제출합니다. #170

Merged
merged 3 commits into from
Sep 23, 2022
Merged

[MVC 구현하기 - 1단계] 레넌(조형래) 미션 제출합니다. #170

merged 3 commits into from
Sep 23, 2022

Conversation

brorae
Copy link

@brorae brorae commented Sep 20, 2022 •
edited
Loading

안녕하세요. 헌치!
만들다 보니 Handler Adapter까지 만들게 되었어요.
리뷰 잘 부탁드립니다!

BETTERFUTURE4
BETTERFUTURE4 suggested changes Sep 21, 2022
View reviewed changes
Copy link

@BETTERFUTURE4 BETTERFUTURE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반가워요 레넌!👋 늦은 리뷰 죄송합니다ㅎ...
깔끔하게, 요구사항에 맞춰 구현해주셨네요!💯
몇가지 피드백(과 질문) 드렸어요.
디엠이나 답글 달아주세요!

추가로, 테스트코드와 README.md 등 코드를 설명해줄 부분들이 없네요.
혹시 여유가 되신다면 2단계 때는 주요 테스트케이스를 추가해주셔도 좋을 것 같아요!😉

mvc/src/main/java/nextstep/mvc/DispatcherServlet.java Show resolved Hide resolved
app/src/main/java/com/techcourse/AppWebApplicationInitializer.java Show resolved Hide resolved
mvc/src/main/java/nextstep/mvc/controller/ManualHandlerAdapter.java Show resolved Hide resolved
app/src/main/java/com/techcourse/AppWebApplicationInitializer.java Show resolved Hide resolved
mvc/src/main/java/nextstep/mvc/DispatcherServlet.java Show resolved Hide resolved
mvc/src/main/java/nextstep/mvc/controller/tobe/HandlerExecution.java Outdated Show resolved Hide resolved
mvc/src/main/java/nextstep/mvc/controller/tobe/AnnotationHandlerMapping.java Outdated Show resolved Hide resolved
mvc/src/main/java/nextstep/mvc/controller/tobe/AnnotationHandlerMapping.java Show resolved Hide resolved
BETTERFUTURE4
BETTERFUTURE4 approved these changes Sep 23, 2022
View reviewed changes
Copy link

@BETTERFUTURE4 BETTERFUTURE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 리뷰 반영해주신 것 확인했습니다.
이번 미션은 머지할게요! 다음 2단계에서 봐요👋

@BETTERFUTURE4 BETTERFUTURE4 merged commit 6333cd2 into woowacourse:brorae Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BETTERFUTURE4 BETTERFUTURE4 BETTERFUTURE4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brorae @BETTERFUTURE4